[arvados] updated: 2.7.0-6619-gdd263aecac

git repository hosting git at public.arvados.org
Wed May 29 14:30:33 UTC 2024


Summary of changes:
 services/workbench2/cypress/e2e/banner-tooltip.cy.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

       via  dd263aecac743dabaffa580767b5628806263392 (commit)
      from  a3b836eb87c2a94b009a564510538e46cb5e083a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit dd263aecac743dabaffa580767b5628806263392
Author: Lisa Knox <lisaknox83 at gmail.com>
Date:   Wed May 29 10:30:28 2024 -0400

    21704: clarified comments
    
    Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox at curii.com>

diff --git a/services/workbench2/cypress/e2e/banner-tooltip.cy.js b/services/workbench2/cypress/e2e/banner-tooltip.cy.js
index 35d8bde374..7cb2bc405e 100644
--- a/services/workbench2/cypress/e2e/banner-tooltip.cy.js
+++ b/services/workbench2/cypress/e2e/banner-tooltip.cy.js
@@ -61,7 +61,11 @@ describe('Banner / tooltip tests', function () {
 
         //login here instead of in specific tests to preserve localStorage and intercept listener
         cy.loginAs(adminUser);
+
+        //must be in localstorage to have banner option in notifications menu
+        //it doesn't matter what the value is, as long as it's truthy
         window.localStorage.setItem('bannerFileData', 'foo');
+
         cy.intercept({ method: 'GET', url: '**/arvados/v1/config?nocache=*' }, (req) => {
             req.on('response', (res) => {
                 res.body.Workbench.BannerUUID = collectionUUID;
@@ -75,7 +79,7 @@ describe('Banner / tooltip tests', function () {
     });
 
     it('should re-show the banner', () => {
-        //reload instead of cy.loginas() to preserve localStorage and intercept listener
+        //reload instead of cy.loginAs() to preserve localStorage and intercept listener
         //logged in as adminUser
         cy.reload();
         cy.waitForDom();

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list