[arvados] updated: 2.7.0-6618-ga3b836eb87

[git repository hosting]

Summary of changes:
 services/workbench2/cypress/e2e/banner-tooltip.cy.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

       via  a3b836eb87c2a94b009a564510538e46cb5e083a (commit)
      from  0b7567c68696515d7511a0696dbe3d1c42d3a85a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit a3b836eb87c2a94b009a564510538e46cb5e083a
Author: Lisa Knox <lisaknox83 at gmail.com>
Date:   Wed May 29 10:22:52 2024 -0400

    21704: added more comments
    
    Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox at curii.com>

diff --git a/services/workbench2/cypress/e2e/banner-tooltip.cy.js b/services/workbench2/cypress/e2e/banner-tooltip.cy.js
index bd57863c94..35d8bde374 100644
--- a/services/workbench2/cypress/e2e/banner-tooltip.cy.js
+++ b/services/workbench2/cypress/e2e/banner-tooltip.cy.js
@@ -4,7 +4,6 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 describe('Banner / tooltip tests', function () {
-    let activeUser;
     let adminUser;
     let collectionUUID;
 
@@ -17,11 +16,6 @@ describe('Banner / tooltip tests', function () {
             .as('adminUser').then(function () {
                 adminUser = this.adminUser;
             });
-        cy.getUser('collectionuser1', 'Collection', 'User', false, true)
-            .as('activeUser').then(function () {
-                activeUser = this.activeUser;
-            });
-
         cy.getAll('@adminUser').then(([adminUser]) => {
             // This collection will not be deleted after each test, we'll
             // clean it up manually.
@@ -64,6 +58,8 @@ describe('Banner / tooltip tests', function () {
                 return false;
             }
         });
+
+        //login here instead of in specific tests to preserve localStorage and intercept listener
         cy.loginAs(adminUser);
         window.localStorage.setItem('bannerFileData', 'foo');
         cy.intercept({ method: 'GET', url: '**/arvados/v1/config?nocache=*' }, (req) => {
@@ -84,14 +80,18 @@ describe('Banner / tooltip tests', function () {
         cy.reload();
         cy.waitForDom();
 
+        //check that banner appears on reload
         cy.waitForDom().get('[data-cy=confirmation-dialog]', {timeout: 10000}).should('be.visible');
         cy.get('[data-cy=confirmation-dialog-ok-btn]').click();
         cy.waitForDom().get('[data-cy=confirmation-dialog]', {timeout: 10000}).should('not.exist');
 
+        //check that banner appears on toggle
         cy.get('[title=Notifications]').click();
         cy.get('li').contains('Restore Banner').click();
 
         cy.waitForDom().get('[data-cy=confirmation-dialog-ok-btn]', {timeout: 10000}).should('be.visible');
+        cy.get('[data-cy=confirmation-dialog-ok-btn]').click();
+        cy.waitForDom().get('[data-cy=confirmation-dialog]', {timeout: 10000}).should('not.exist');
     });
 
 
@@ -101,6 +101,7 @@ describe('Banner / tooltip tests', function () {
         cy.reload();
         cy.waitForDom();
 
+        //banner appears on reload
         cy.waitForDom().get('[data-cy=confirmation-dialog]', {timeout: 10000}).should('be.visible');
         cy.get('[data-cy=confirmation-dialog-ok-btn]').click();
         cy.waitForDom().get('[data-cy=confirmation-dialog]', {timeout: 10000}).should('not.exist');

-----------------------------------------------------------------------


hooks/post-receive
--