[ARVADOS] updated: e675118bd2b28ec40833d06ea384b6f1c78f3039

Git user git at public.curoverse.com
Mon Nov 28 15:03:46 EST 2016


Summary of changes:
 services/keepstore/s3_volume_test.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

       via  e675118bd2b28ec40833d06ea384b6f1c78f3039 (commit)
      from  267898c1b23b78d433ef01ddd2da8a444616e088 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e675118bd2b28ec40833d06ea384b6f1c78f3039
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Nov 28 15:02:51 2016 -0500

    10467: Update var names in parameterized test func.

diff --git a/services/keepstore/s3_volume_test.go b/services/keepstore/s3_volume_test.go
index 3fc5639..c43b85b 100644
--- a/services/keepstore/s3_volume_test.go
+++ b/services/keepstore/s3_volume_test.go
@@ -174,11 +174,11 @@ func (s *StubbedS3Suite) testContextCancel(c *check.C, testFunc func(context.Con
 	handler.unblock = make(chan struct{})
 	defer close(handler.unblock)
 
-	doneGet := make(chan struct{})
+	doneFunc := make(chan struct{})
 	go func() {
 		err := testFunc(ctx, v)
 		c.Check(err, check.Equals, context.Canceled)
-		close(doneGet)
+		close(doneFunc)
 	}()
 
 	timeout := time.After(10 * time.Second)
@@ -187,9 +187,9 @@ func (s *StubbedS3Suite) testContextCancel(c *check.C, testFunc func(context.Con
 	// Get() is waiting for an s3 operation.
 	select {
 	case <-timeout:
-		c.Fatal("timed out waiting for Get to call our handler")
-	case <-doneGet:
-		c.Fatal("Get finished without calling our handler!")
+		c.Fatal("timed out waiting for test func to call our handler")
+	case <-doneFunc:
+		c.Fatal("test func finished without even calling our handler!")
 	case <-handler.requested:
 	}
 
@@ -198,7 +198,7 @@ func (s *StubbedS3Suite) testContextCancel(c *check.C, testFunc func(context.Con
 	select {
 	case <-timeout:
 		c.Fatal("timed out")
-	case <-doneGet:
+	case <-doneFunc:
 	}
 }
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list