[ARVADOS] updated: 267898c1b23b78d433ef01ddd2da8a444616e088

[Git user]

Summary of changes:
 services/keepstore/s3_volume_test.go | 35 ++++++++++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 7 deletions(-)

       via  267898c1b23b78d433ef01ddd2da8a444616e088 (commit)
      from  a8eec5a3443447ad7a31bd286ae7beabb8ca9e9d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 267898c1b23b78d433ef01ddd2da8a444616e088
Author: Tom Clegg <tom at curoverse.com>
Date:   Mon Nov 28 14:59:05 2016 -0500

    10467: Add "context canceled" tests for PUT and HEAD.

diff --git a/services/keepstore/s3_volume_test.go b/services/keepstore/s3_volume_test.go
index 702e553..3fc5639 100644
--- a/services/keepstore/s3_volume_test.go
+++ b/services/keepstore/s3_volume_test.go
@@ -129,10 +129,35 @@ func (h *blockingHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	http.Error(w, "nothing here", http.StatusNotFound)
 }
 
-func (s *StubbedS3Suite) TestClientDisconnect(c *check.C) {
+func (s *StubbedS3Suite) TestGetContextCancel(c *check.C) {
 	loc := "acbd18db4cc2f85cedef654fccc4a4d8"
 	buf := make([]byte, 3)
 
+	s.testContextCancel(c, func(ctx context.Context, v *TestableS3Volume) error {
+		_, err := v.Get(ctx, loc, buf)
+		return err
+	})
+}
+
+func (s *StubbedS3Suite) TestCompareContextCancel(c *check.C) {
+	loc := "acbd18db4cc2f85cedef654fccc4a4d8"
+	buf := []byte("bar")
+
+	s.testContextCancel(c, func(ctx context.Context, v *TestableS3Volume) error {
+		return v.Compare(ctx, loc, buf)
+	})
+}
+
+func (s *StubbedS3Suite) TestPutContextCancel(c *check.C) {
+	loc := "acbd18db4cc2f85cedef654fccc4a4d8"
+	buf := []byte("foo")
+
+	s.testContextCancel(c, func(ctx context.Context, v *TestableS3Volume) error {
+		return v.Put(ctx, loc, buf)
+	})
+}
+
+func (s *StubbedS3Suite) testContextCancel(c *check.C, testFunc func(context.Context, *TestableS3Volume) error) {
 	handler := &blockingHandler{}
 	srv := httptest.NewServer(handler)
 	defer srv.Close()
@@ -149,11 +174,10 @@ func (s *StubbedS3Suite) TestClientDisconnect(c *check.C) {
 	handler.unblock = make(chan struct{})
 	defer close(handler.unblock)
 
-	var n int
-	var err error
 	doneGet := make(chan struct{})
 	go func() {
-		n, err = v.Get(ctx, loc, buf)
+		err := testFunc(ctx, v)
+		c.Check(err, check.Equals, context.Canceled)
 		close(doneGet)
 	}()
 
@@ -175,9 +199,6 @@ func (s *StubbedS3Suite) TestClientDisconnect(c *check.C) {
 	case <-timeout:
 		c.Fatal("timed out")
 	case <-doneGet:
-		c.Check(n, check.Equals, 0)
-		c.Check(err, check.NotNil)
-		c.Check(err, check.Equals, context.Canceled)
 	}
 }
 

-----------------------------------------------------------------------


hooks/post-receive
--