[ARVADOS] updated: 0313947c4cb1ece72d808d35a76e0751080ee083

git at public.curoverse.com git at public.curoverse.com
Thu Aug 28 09:22:47 EDT 2014


Summary of changes:
 apps/workbench/test/integration/errors_test.rb       | 6 ++++--
 apps/workbench/test/integration/report_issue_test.rb | 6 ++++--
 apps/workbench/test/integration/search_box_test.rb   | 6 ++++--
 services/api/Gemfile                                 | 2 +-
 services/api/Gemfile.lock                            | 6 +++---
 5 files changed, 16 insertions(+), 10 deletions(-)

       via  0313947c4cb1ece72d808d35a76e0751080ee083 (commit)
       via  7b2779229a9733af23fda818d50607bf42e9c1bf (commit)
       via  a3755ca0b2ee6b7194f02b368d44cf08d25272ce (commit)
       via  15907a131ea18b0671287f7a962d466fec894913 (commit)
      from  d2804a5fc6132a8c1067eafde336e70dd841a61b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 0313947c4cb1ece72d808d35a76e0751080ee083
Author: radhika <radhika at curoverse.com>
Date:   Thu Aug 28 09:22:00 2014 -0400

    3714: update tests to verify that the send report button is disabled until problem description is entered.

diff --git a/apps/workbench/test/integration/errors_test.rb b/apps/workbench/test/integration/errors_test.rb
index 4210191..ce90068 100644
--- a/apps/workbench/test/integration/errors_test.rb
+++ b/apps/workbench/test/integration/errors_test.rb
@@ -104,15 +104,17 @@ class ErrorsTest < ActionDispatch::IntegrationTest
         assert page.has_text?('Report a problem'), 'Report a problem text not found'
         assert page.has_no_text?('Version / debugging info'), 'Version / debugging info is not expected'
         assert page.has_text?('Describe the problem'), 'Describe the problem text not found'
-        assert page.has_button?('Send problem report'), 'Send problem report button not found'
+        assert page.has_text?('Send problem report'), 'Send problem report button text is not found'
+        assert page.has_no_button?('Send problem report'), 'Send problem report button is not disabled before entering problem description'
         assert page.has_button?('Cancel'), 'Cancel button not found'
 
         # enter a report text and click on report
         page.find_field('report_issue_text').set 'my test report text'
+        assert page.has_button?('Send problem report'), 'Send problem report button not enabled after entering text'
         click_button 'Send problem report'
 
         # ajax success updated button texts and added footer message
-        assert page.has_no_button?('Send problem report'), 'Found button - Send problem report'
+        assert page.has_no_text?('Send problem report'), 'Found button - Send problem report'
         assert page.has_no_button?('Cancel'), 'Found button - Cancel'
         assert page.has_text?('Report sent'), 'No text - Report sent'
         assert page.has_button?('Close'), 'No button - Close'
diff --git a/apps/workbench/test/integration/report_issue_test.rb b/apps/workbench/test/integration/report_issue_test.rb
index cf41e23..ebedce3 100644
--- a/apps/workbench/test/integration/report_issue_test.rb
+++ b/apps/workbench/test/integration/report_issue_test.rb
@@ -53,15 +53,17 @@ class ReportIssueTest < ActionDispatch::IntegrationTest
       assert page.has_no_text?('Version / debugging info'), 'Found text - Version / debugging info'
       assert page.has_text?('Describe the problem'), 'No text - Describe the problem'
       assert page.has_no_button?('Close'), 'Found button - Close'
-      assert page.has_button?('Send problem report'), 'No button - Send problem report'
+      assert page.has_text?('Send problem report'), 'Send problem report button text is not found'
+      assert page.has_no_button?('Send problem report'), 'Send problem report button is not disabled before entering problem description'
       assert page.has_button?('Cancel'), 'No button - Cancel'
 
       # enter a report text and click on report
       page.find_field('report_issue_text').set 'my test report text'
+        assert page.has_button?('Send problem report'), 'Send problem report button not enabled after entering text'
       click_button 'Send problem report'
 
       # ajax success updated button texts and added footer message
-      assert page.has_no_button?('Send problem report'), 'Found button - Send problem report'
+      assert page.has_no_text?('Send problem report'), 'Found button - Send problem report'
       assert page.has_no_button?('Cancel'), 'Found button - Cancel'
       assert page.has_text?('Report sent'), 'No text - Report sent'
       assert page.has_button?('Close'), 'No text - Close'
diff --git a/apps/workbench/test/integration/search_box_test.rb b/apps/workbench/test/integration/search_box_test.rb
index dbb5131..9a259e2 100644
--- a/apps/workbench/test/integration/search_box_test.rb
+++ b/apps/workbench/test/integration/search_box_test.rb
@@ -38,15 +38,17 @@ class SearchBoxTest < ActionDispatch::IntegrationTest
         assert page.has_text?('Report a problem'), 'No text - Report a problem'
         assert page.has_no_text?('Version / debugging info'), 'No text - Version / debugging info'
         assert page.has_text?('Describe the problem'), 'No text - Describe the problem'
-        assert page.has_button?('Send problem report'), 'No button - Send problem report'
+        assert page.has_text?('Send problem report'), 'Send problem report button text is not found'
+        assert page.has_no_button?('Send problem report'), 'Send problem report button is not disabled before entering problem description'
         assert page.has_button?('Cancel'), 'No button - Cancel'
 
         # enter a report text and click on report
         page.find_field('report_issue_text').set 'my test report text'
+        assert page.has_button?('Send problem report'), 'Send problem report button not enabled after entering text'
         click_button 'Send problem report'
 
         # ajax success updated button texts and added footer message
-        assert page.has_no_button?('Send problem report'), 'Found button - Send problem report'
+        assert page.has_no_text?('Send problem report'), 'Found button - Send problem report'
         assert page.has_no_button?('Cancel'), 'Found button - Cancel'
         assert page.has_text?('Report sent'), 'No text - Report sent'
         assert page.has_button?('Close'), 'No text - Close'

commit 7b2779229a9733af23fda818d50607bf42e9c1bf
Merge: d2804a5 a3755ca
Author: radhika <radhika at curoverse.com>
Date:   Thu Aug 28 09:17:06 2014 -0400

    Merge branch 'master' into 3714-report-issue-issues


-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list