[ARVADOS] updated: a20025f9ce967ae845e3c675d764d4d1ce4f4f2c

git at public.curoverse.com git at public.curoverse.com
Thu Apr 3 14:21:00 EDT 2014


Summary of changes:
 sdk/cli/bin/crunch-job |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

       via  a20025f9ce967ae845e3c675d764d4d1ce4f4f2c (commit)
      from  9454df6ea65e3afa9586cabea34abc42c328bd65 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit a20025f9ce967ae845e3c675d764d4d1ce4f4f2c
Author: Tim Pierce <twp at curoverse.com>
Date:   Thu Apr 3 14:22:10 2014 -0400

    Use quotemeta to protect shell escapes (refs #2221, #2325)

diff --git a/sdk/cli/bin/crunch-job b/sdk/cli/bin/crunch-job
index 40b0033..e81628c 100755
--- a/sdk/cli/bin/crunch-job
+++ b/sdk/cli/bin/crunch-job
@@ -758,7 +758,7 @@ if ($job_has_uuid) {
 if ($Job->{'output'})
 {
   eval {
-    my $manifest_text = `arv keep get $Job->{'output'}`;
+    my $manifest_text = `arv keep get \Q$Job->{'output'}\E`;
     $arv->{'collections'}->{'create'}->execute('collection' => {
       'uuid' => $Job->{'output'},
       'manifest_text' => $manifest_text,
@@ -1223,7 +1223,8 @@ sub save_meta
   return if $justcheckpoint;  # checkpointing is not relevant post-Warehouse.pm
 
   $local_logfile->flush;
-  my $cmd = "arv keep put --filename $keep_logfile ". $local_logfile->filename;
+  my $cmd = "arv keep put --filename \Q$keep_logfile\E "
+      . quotemeta($local_logfile->filename);
   my $loglocator = `$cmd`;
   die "system $cmd failed: $?" if $?;
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list