[arvados] updated: 2.7.0-6842-g7223714878

git repository hosting git at public.arvados.org
Mon Jun 3 22:42:30 UTC 2024


Summary of changes:
 services/workbench2/cypress/e2e/favorites.cy.js           | 2 +-
 services/workbench2/src/views-components/baner/banner.tsx | 8 +++++---
 2 files changed, 6 insertions(+), 4 deletions(-)

       via  7223714878b7ff520c58261d12e0b3e9f5aa5c8d (commit)
      from  999a178f1b661e1221a035b4454de1b24231dde1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 7223714878b7ff520c58261d12e0b3e9f5aa5c8d
Author: Lisa Knox <lisaknox83 at gmail.com>
Date:   Mon Jun 3 18:42:23 2024 -0400

    21811: fixed banner test
    
    Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox at curii.com>

diff --git a/services/workbench2/cypress/e2e/favorites.cy.js b/services/workbench2/cypress/e2e/favorites.cy.js
index aa1ece51ef..d4f0d8b431 100644
--- a/services/workbench2/cypress/e2e/favorites.cy.js
+++ b/services/workbench2/cypress/e2e/favorites.cy.js
@@ -255,7 +255,7 @@ describe('Favorites tests', function () {
             });
     });
 
-    it.only('shows the correct favorites and public favorites in the side panel', () => {
+    it('shows the correct favorites and public favorites in the side panel', () => {
         cy.createProject({
             owningUser: adminUser,
             projectName: 'myFavoriteProject1',
diff --git a/services/workbench2/src/views-components/baner/banner.tsx b/services/workbench2/src/views-components/baner/banner.tsx
index 79fe888616..99b3ca3aa2 100644
--- a/services/workbench2/src/views-components/baner/banner.tsx
+++ b/services/workbench2/src/views-components/baner/banner.tsx
@@ -61,6 +61,7 @@ export const BannerComponent = (props: BannerComponentProps) => {
 
     useEffect(() => {
         if (!!bannerUUID && bannerUUID !== "") {
+        try {
             servicesProvider
                 .getServices()
                 .collectionService.files(bannerUUID)
@@ -82,9 +83,10 @@ export const BannerComponent = (props: BannerComponentProps) => {
                                 localStorage.setItem(BANNER_LOCAL_STORAGE_KEY, JSON.stringify(bannerFileData));
                             });
                     }
-                }).catch((e) => {
-		    console.error("Failed to load banner", e);
-		});
+                })
+            } catch (error) {
+                console.error("Failed to load banner", error);
+            }
         }
     }, [bannerUUID, keepWebInlineServiceUrl, openBanner, isOpen]);
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list