[arvados-workbench2] updated: 2.6.0-96-g6271a0f3
git repository hosting
git at public.arvados.org
Wed Sep 13 23:36:10 UTC 2023
Summary of changes:
src/components/data-table/data-table.tsx | 2 +-
src/store/trash/trash-actions.ts | 60 ++++++++++++++++----------------
2 files changed, 31 insertions(+), 31 deletions(-)
via 6271a0f335b359cde84a04dbf4d4f07f63ca7fc6 (commit)
from ba0c5cf6838e36740881c4dd9639043b527bf82d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 6271a0f335b359cde84a04dbf4d4f07f63ca7fc6
Author: Lisa Knox <lisaknox83 at gmail.com>
Date: Wed Sep 13 19:35:58 2023 -0400
15768: fixed double error messages Arvados-DCO-1.1-Signed-off-by: Lisa Knox <lisa.knox at curii.com>
diff --git a/src/components/data-table/data-table.tsx b/src/components/data-table/data-table.tsx
index 59e15413..96f03651 100644
--- a/src/components/data-table/data-table.tsx
+++ b/src/components/data-table/data-table.tsx
@@ -169,7 +169,7 @@ export const DataTable = withStyles(styles)(
type="checkbox"
name={uuid}
className={classes.checkBox}
- checked={checkedList ? checkedList[uuid] : false}
+ checked={checkedList[uuid] ? checkedList[uuid] : false}
onChange={() => this.handleSelectOne(uuid)}
onDoubleClick={ev => ev.stopPropagation()}></input>
);
diff --git a/src/store/trash/trash-actions.ts b/src/store/trash/trash-actions.ts
index 96726422..e999719d 100644
--- a/src/store/trash/trash-actions.ts
+++ b/src/store/trash/trash-actions.ts
@@ -2,32 +2,32 @@
//
// SPDX-License-Identifier: AGPL-3.0
-import { Dispatch } from 'redux';
-import { RootState } from 'store/store';
-import { ServiceRepository } from 'services/services';
-import { snackbarActions, SnackbarKind } from 'store/snackbar/snackbar-actions';
-import { trashPanelActions } from 'store/trash-panel/trash-panel-action';
-import { activateSidePanelTreeItem, loadSidePanelTreeProjects } from 'store/side-panel-tree/side-panel-tree-actions';
-import { projectPanelActions } from 'store/project-panel/project-panel-action';
-import { ResourceKind } from 'models/resource';
-import { navigateTo, navigateToTrash } from 'store/navigation/navigation-action';
-import { matchCollectionRoute } from 'routes/routes';
+import { Dispatch } from "redux";
+import { RootState } from "store/store";
+import { ServiceRepository } from "services/services";
+import { snackbarActions, SnackbarKind } from "store/snackbar/snackbar-actions";
+import { trashPanelActions } from "store/trash-panel/trash-panel-action";
+import { activateSidePanelTreeItem, loadSidePanelTreeProjects } from "store/side-panel-tree/side-panel-tree-actions";
+import { projectPanelActions } from "store/project-panel/project-panel-action";
+import { ResourceKind } from "models/resource";
+import { navigateTo, navigateToTrash } from "store/navigation/navigation-action";
+import { matchCollectionRoute } from "routes/routes";
export const toggleProjectTrashed =
(uuid: string, ownerUuid: string, isTrashed: boolean, isMulti: boolean) =>
async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository): Promise<any> => {
- let errorMessage = '';
- let successMessage = '';
+ let errorMessage = "";
+ let successMessage = "";
try {
if (isTrashed) {
- errorMessage = 'Could not restore project from trash';
- successMessage = 'Restored from trash';
+ errorMessage = "Could not restore project from trash";
+ successMessage = "Restored project from trash";
await services.groupsService.untrash(uuid);
dispatch<any>(isMulti ? navigateToTrash : navigateTo(uuid));
dispatch<any>(activateSidePanelTreeItem(uuid));
} else {
- errorMessage = 'Could not move project to trash';
- successMessage = 'Added to trash';
+ errorMessage = "Could not move project to trash";
+ successMessage = "Added to trash";
await services.groupsService.trash(uuid);
dispatch<any>(loadSidePanelTreeProjects(ownerUuid));
dispatch<any>(navigateTo(ownerUuid));
@@ -52,24 +52,31 @@ export const toggleProjectTrashed =
export const toggleCollectionTrashed =
(uuid: string, isTrashed: boolean) =>
async (dispatch: Dispatch, getState: () => RootState, services: ServiceRepository): Promise<any> => {
- let errorMessage = '';
- let successMessage = '';
+ let errorMessage = "";
+ let successMessage = "";
try {
if (isTrashed) {
const { location } = getState().router;
- errorMessage = 'Could not restore collection from trash';
- successMessage = 'Restored from trash';
+ errorMessage = "Could not restore collection from trash";
+ successMessage = "Restored from trash";
await services.collectionService.untrash(uuid);
- if (matchCollectionRoute(location ? location.pathname : '')) {
+ if (matchCollectionRoute(location ? location.pathname : "")) {
dispatch(navigateToTrash);
}
dispatch(trashPanelActions.REQUEST_ITEMS());
} else {
- errorMessage = 'Could not move collection to trash';
- successMessage = 'Added to trash';
+ errorMessage = "Could not move collection to trash";
+ successMessage = "Added to trash";
await services.collectionService.trash(uuid);
dispatch(projectPanelActions.REQUEST_ITEMS());
}
+ dispatch(
+ snackbarActions.OPEN_SNACKBAR({
+ message: successMessage,
+ hideDuration: 2000,
+ kind: SnackbarKind.SUCCESS,
+ })
+ );
} catch (e) {
dispatch(
snackbarActions.OPEN_SNACKBAR({
@@ -78,13 +85,6 @@ export const toggleCollectionTrashed =
})
);
}
- dispatch(
- snackbarActions.OPEN_SNACKBAR({
- message: successMessage,
- hideDuration: 2000,
- kind: SnackbarKind.SUCCESS,
- })
- );
};
export const toggleTrashed = (kind: ResourceKind, uuid: string, ownerUuid: string, isTrashed: boolean) => (dispatch: Dispatch) => {
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list