[arvados] updated: 2.6.0-595-g2fe4245dc2

[git repository hosting]

Summary of changes:
 lib/dispatchcloud/dispatcher_test.go | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

       via  2fe4245dc28c738fca783b83bcae65c213da41bc (commit)
      from  fd507a52e72e992a3fd19309de65905341630396 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 2fe4245dc28c738fca783b83bcae65c213da41bc
Author: Tom Clegg <tom at curii.com>
Date:   Tue Sep 12 13:52:24 2023 -0400

    Fix flaky dispatchcloud test.
    
    No issue #
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curii.com>

diff --git a/lib/dispatchcloud/dispatcher_test.go b/lib/dispatchcloud/dispatcher_test.go
index a981d83a26..6c057edc70 100644
--- a/lib/dispatchcloud/dispatcher_test.go
+++ b/lib/dispatchcloud/dispatcher_test.go
@@ -214,13 +214,23 @@ func (s *DispatcherSuite) TestDispatchToStubDriver(c *check.C) {
 		stubvm.ExecuteContainer = executeContainer
 		stubvm.CrashRunningContainer = finishContainer
 		stubvm.ExtraCrunchRunArgs = "'--runtime-engine=stub' '--foo' '--extra='\\''args'\\'''"
-		switch n % 7 {
-		case 0:
+		switch {
+		case n%7 == 0:
+			// some instances start out OK but then stop
+			// running any commands
 			stubvm.Broken = time.Now().Add(time.Duration(rand.Int63n(90)) * time.Millisecond)
-		case 1:
+		case n%7 == 1:
+			// some instances never pass a run-probe
 			stubvm.CrunchRunMissing = true
-		case 2:
+		case n%7 == 2:
+			// some instances start out OK but then start
+			// reporting themselves as broken
 			stubvm.ReportBroken = time.Now().Add(time.Duration(rand.Int63n(200)) * time.Millisecond)
+		case n == 3:
+			// 1 instance is completely broken, ensuring
+			// the boot_outcomes{outcome="failure"} metric
+			// is not zero
+			stubvm.CrunchRunCrashRate = 1
 		default:
 			stubvm.CrunchRunCrashRate = 0.1
 			stubvm.ArvMountDeadlockRate = 0.1

-----------------------------------------------------------------------


hooks/post-receive
--