[arvados-workbench2] created: 2.6.0-5-gff3197c8

git repository hosting git at public.arvados.org
Wed May 10 13:00:10 UTC 2023


        at  ff3197c85e5520569eb8d67edaa9b7e9bc2ba427 (commit)


commit ff3197c85e5520569eb8d67edaa9b7e9bc2ba427
Author: Stephen Smith <stephen at curii.com>
Date:   Wed May 10 08:59:37 2023 -0400

    20377: Reject dataexplorer updates to incorrect page, allows dataexplorer to retry with correct page
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/src/store/data-explorer/data-explorer-reducer.ts b/src/store/data-explorer/data-explorer-reducer.ts
index e93d291d..509fe054 100644
--- a/src/store/data-explorer/data-explorer-reducer.ts
+++ b/src/store/data-explorer/data-explorer-reducer.ts
@@ -70,14 +70,23 @@ export const dataExplorerReducer = (
         SET_FILTERS: ({ id, columnName, filters }) =>
             update(state, id, mapColumns(setFilters(columnName, filters))),
 
-        SET_ITEMS: ({ id, items, itemsAvailable, page, rowsPerPage }) =>
-            update(state, id, (explorer) => ({
-                ...explorer,
-                items,
-                itemsAvailable,
-                page: page || 0,
-                rowsPerPage,
-            })),
+        SET_ITEMS: ({ id, items, itemsAvailable, page, rowsPerPage }) => (
+            update(state, id, (explorer) => {
+                // Reject updates to pages other than current,
+                //  DataExplorer middleware should retry
+                if (explorer.page === page) {
+                    return {
+                        ...explorer,
+                        items,
+                        itemsAvailable,
+                        page: page || 0,
+                        rowsPerPage,
+                    }
+                } else {
+                    return explorer;
+                }
+            })
+        ),
 
         APPEND_ITEMS: ({ id, items, itemsAvailable, page, rowsPerPage }) =>
             update(state, id, (explorer) => ({

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list