[arvados] updated: 2.6.0-119-ge3962b41a

git repository hosting git at public.arvados.org
Tue May 9 15:20:23 UTC 2023


Summary of changes:
 sdk/python/tests/test_arvfile.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

       via  e3962b41ad01780c1b173892f0a5c947449a0ed8 (commit)
      from  38bae05cc62fa136960d4336a3aa23c94d70173b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e3962b41ad01780c1b173892f0a5c947449a0ed8
Author: Brett Smith <brett.smith at curii.com>
Date:   Tue May 9 11:16:22 2023 -0400

    12684: Use mock services in arvfile sparse write tests
    
    Without these mocks, Jenkins seems to spend a lot of time retrying
    requests—although weirdly, I don't see that in my own development
    environment.
    
    I believe the mocks were always intended to be used, since they're
    instantiated and already used in other sparse write tests. To me this
    looks like an oversight when the previous tests were adapted to write
    new collections.
    
    Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith at curii.com>

diff --git a/sdk/python/tests/test_arvfile.py b/sdk/python/tests/test_arvfile.py
index b45a592ec..691716b3f 100644
--- a/sdk/python/tests/test_arvfile.py
+++ b/sdk/python/tests/test_arvfile.py
@@ -414,7 +414,7 @@ class ArvadosFileWriterTestCase(unittest.TestCase):
         keep = ArvadosFileWriterTestCase.MockKeep({})
         api = ArvadosFileWriterTestCase.MockApi({}, {})
         for r in [[0, 1, 2, 3, 4], [4, 3, 2, 1, 0], [3, 2, 0, 4, 1]]:
-            with Collection() as c:
+            with Collection(api_client=api, keep_client=keep) as c:
                 writer = c.open("count.txt", "rb+")
                 self.assertEqual(writer.size(), 0)
 
@@ -429,7 +429,7 @@ class ArvadosFileWriterTestCase(unittest.TestCase):
         keep = ArvadosFileWriterTestCase.MockKeep({})
         api = ArvadosFileWriterTestCase.MockApi({}, {})
         for r in [[0, 1, 2, 4], [4, 2, 1, 0], [2, 0, 4, 1]]:
-            with Collection() as c:
+            with Collection(api_client=api, keep_client=keep) as c:
                 writer = c.open("count.txt", "rb+")
                 self.assertEqual(writer.size(), 0)
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list