[arvados] updated: 2.5.0-227-g843fc048d
git repository hosting
git at public.arvados.org
Sat Mar 4 14:52:03 UTC 2023
Summary of changes:
services/api/app/models/container_request.rb | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
via 843fc048d7500fef8a461db4e8b6022d5c4b0e24 (commit)
from 1116589dd94d168b920b20340491472e2d0c8c2a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 843fc048d7500fef8a461db4e8b6022d5c4b0e24
Author: Brett Smith <brett.smith at curii.com>
Date: Sat Mar 4 09:50:36 2023 -0500
16325: Document the purposes of the different log collections
From discussion in refs #16325.
Arvados-DCO-1.1-Signed-off-by: Brett Smith <brett.smith at curii.com>
diff --git a/services/api/app/models/container_request.rb b/services/api/app/models/container_request.rb
index e4da8399f..0701adb32 100644
--- a/services/api/app/models/container_request.rb
+++ b/services/api/app/models/container_request.rb
@@ -200,7 +200,14 @@ class ContainerRequest < ArvadosModel
end
update_collections(container: container)
-
+ # update_collections makes a log collection that includes all of the logs
+ # for all of the containers associated with this request. For requests
+ # that are retried, this is the primary way users can get logs for
+ # failed containers.
+ # The code below makes a log collection that is a verbatim copy of the
+ # container's logs. This is required for container reuse: a container
+ # will not be reused if the owner cannot read a collection with its logs.
+ # See the "readable log" section of Container.find_reusable().
if container.state == Container::Complete
log_col = Collection.where(portable_data_hash: container.log).first
if log_col
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list