[arvados] updated: 2.6.0-326-gc8dc89d59

git repository hosting git at public.arvados.org
Tue Jun 27 14:36:54 UTC 2023


Summary of changes:
 services/api/test/unit/container_test.rb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

       via  c8dc89d59755226183a50de2e5d679548bcb984b (commit)
      from  9ef184fa59507f3fe6b19f3b2fe77699f30499ee (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit c8dc89d59755226183a50de2e5d679548bcb984b
Author: Tom Clegg <tom at curii.com>
Date:   Tue Jun 27 10:36:08 2023 -0400

    20606: Update retry tests.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curii.com>

diff --git a/services/api/test/unit/container_test.rb b/services/api/test/unit/container_test.rb
index 300c73ed5..cb9cd7503 100644
--- a/services/api/test/unit/container_test.rb
+++ b/services/api/test/unit/container_test.rb
@@ -1169,6 +1169,12 @@ class ContainerTest < ActiveSupport::TestCase
     preemptible_values.product(preemptible_values),
     preemptible_values.product(preemptible_values, preemptible_values),
   ).each do |preemptible_a|
+    # If the first req has preemptible=true but a subsequent req
+    # doesn't, we want to avoid reusing the first container, so this
+    # test isn't appropriate.
+    next if preemptible_a[0] &&
+            ((preemptible_a.length > 1 && !preemptible_a[1]) ||
+             (preemptible_a.length > 2 && !preemptible_a[2]))
     test "retry requests scheduled with preemptible=#{preemptible_a}" do
       configure_preemptible_instance_type
       param_hashes = vary_parameters(preemptible: preemptible_a)
@@ -1217,14 +1223,14 @@ class ContainerTest < ActiveSupport::TestCase
     configure_preemptible_instance_type
     param_hashes = [{
                      "partitions": ["alpha", "bravo"],
-                     "preemptible": true,
+                     "preemptible": false,
                      "max_run_time": 10,
                     }, {
                      "partitions": ["alpha", "charlie"],
                      "max_run_time": 20,
                     }, {
                      "partitions": ["bravo", "charlie"],
-                     "preemptible": false,
+                     "preemptible": true,
                      "max_run_time": 30,
                     }]
     container = retry_with_scheduling_parameters(param_hashes)

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list