[arvados] updated: 2.1.0-2945-g720bbcb2e
git repository hosting
git at public.arvados.org
Fri Sep 30 21:17:13 UTC 2022
Summary of changes:
.../single_host/multiple_hostnames/states/snakeoil_certs.sls | 8 ++++----
.../single_host/single_hostname/states/snakeoil_certs.sls | 8 ++++----
tools/salt-install/installer.sh | 1 +
3 files changed, 9 insertions(+), 8 deletions(-)
via 720bbcb2eda593e7ecb91522de8f5ab27d0bfd8e (commit)
from 2a375469539ea0fe7c47d8f4ba1726caff99eedb (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 720bbcb2eda593e7ecb91522de8f5ab27d0bfd8e
Author: Peter Amstutz <peter.amstutz at curii.com>
Date: Fri Sep 30 17:16:43 2022 -0400
19215: Explicitly use bash for bash-ism in snakeoil state
Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz at curii.com>
diff --git a/tools/salt-install/config_examples/single_host/multiple_hostnames/states/snakeoil_certs.sls b/tools/salt-install/config_examples/single_host/multiple_hostnames/states/snakeoil_certs.sls
index 8f2fda45b..5f83582bc 100644
--- a/tools/salt-install/config_examples/single_host/multiple_hostnames/states/snakeoil_certs.sls
+++ b/tools/salt-install/config_examples/single_host/multiple_hostnames/states/snakeoil_certs.sls
@@ -65,21 +65,21 @@ extra_snakeoil_certs_arvados_snakeoil_ca_cmd_run:
- name: |
# These dirs are not to CentOS-ish, but this is a helper script
# and they should be enough
- mkdir -p /etc/ssl/certs/ /etc/ssl/private/ && \
+ /bin/bash -c "mkdir -p /etc/ssl/certs/ /etc/ssl/private/ && \
openssl req \
-new \
-nodes \
-sha256 \
-x509 \
- -subj "/C=CC/ST=Some State/O=Arvados Formula/OU=arvados-formula/CN=snakeoil-ca-{{ arvados.cluster.name }}.{{ arvados.cluster.domain }}" \
+ -subj \"/C=CC/ST=Some State/O=Arvados Formula/OU=arvados-formula/CN=snakeoil-ca-{{ arvados.cluster.name }}.{{ arvados.cluster.domain }}\" \
-extensions x509_ext \
-config <(cat {{ openssl_conf }} \
- <(printf "\n[x509_ext]\nbasicConstraints=critical,CA:true,pathlen:0\nkeyUsage=critical,keyCertSign,cRLSign")) \
+ <(printf \"\n[x509_ext]\nbasicConstraints=critical,CA:true,pathlen:0\nkeyUsage=critical,keyCertSign,cRLSign\")) \
-out {{ arvados_ca_cert_file }} \
-keyout {{ arvados_ca_key_file }} \
-days 365 && \
cp {{ arvados_ca_cert_file }} {{ arvados_ca_cert_dest }} && \
- {{ update_ca_cert }}
+ {{ update_ca_cert }}"
- unless:
- test -f {{ arvados_ca_cert_file }}
- openssl verify -CAfile {{ arvados_ca_cert_file }} {{ arvados_ca_cert_file }}
diff --git a/tools/salt-install/config_examples/single_host/single_hostname/states/snakeoil_certs.sls b/tools/salt-install/config_examples/single_host/single_hostname/states/snakeoil_certs.sls
index 4cbdee32f..8d416a8d9 100644
--- a/tools/salt-install/config_examples/single_host/single_hostname/states/snakeoil_certs.sls
+++ b/tools/salt-install/config_examples/single_host/single_hostname/states/snakeoil_certs.sls
@@ -62,21 +62,21 @@ extra_snakeoil_certs_arvados_snakeoil_ca_cmd_run:
- name: |
# These dirs are not too CentOS-ish, but this is a helper script
# and they should be enough
- mkdir -p /etc/ssl/certs/ /etc/ssl/private/ && \
+ /bin/bash -c "mkdir -p /etc/ssl/certs/ /etc/ssl/private/ && \
openssl req \
-new \
-nodes \
-sha256 \
-x509 \
- -subj "/C=CC/ST=Some State/O=Arvados Formula/OU=arvados-formula/CN=snakeoil-ca-{{ arvados.cluster.name }}.{{ arvados.cluster.domain }}" \
+ -subj \"/C=CC/ST=Some State/O=Arvados Formula/OU=arvados-formula/CN=snakeoil-ca-{{ arvados.cluster.name }}.{{ arvados.cluster.domain }}\" \
-extensions x509_ext \
-config <(cat {{ openssl_conf }} \
- <(printf "\n[x509_ext]\nbasicConstraints=critical,CA:true,pathlen:0\nkeyUsage=critical,keyCertSign,cRLSign")) \
+ <(printf \"\n[x509_ext]\nbasicConstraints=critical,CA:true,pathlen:0\nkeyUsage=critical,keyCertSign,cRLSign\")) \
-out {{ arvados_ca_cert_file }} \
-keyout {{ arvados_ca_key_file }} \
-days 365 && \
cp {{ arvados_ca_cert_file }} {{ arvados_ca_cert_dest }} && \
- {{ update_ca_cert }}
+ {{ update_ca_cert }}"
- unless:
- test -f {{ arvados_ca_cert_file }}
- openssl verify -CAfile {{ arvados_ca_cert_file }} {{ arvados_ca_cert_file }}
diff --git a/tools/salt-install/installer.sh b/tools/salt-install/installer.sh
index b8c7e52a6..f294a7ced 100755
--- a/tools/salt-install/installer.sh
+++ b/tools/salt-install/installer.sh
@@ -247,6 +247,7 @@ case "$subcmd" in
deploynode $NODE ""
fi
+ set +x
echo
echo "Completed deploy, run 'installer.sh diagnostics' to verify the install"
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list