[arvados-workbench2] updated: 2.4.0-224-g03d930ad

git repository hosting git at public.arvados.org
Fri Sep 30 14:42:16 UTC 2022


Summary of changes:
 src/views/process-panel/process-io-card.tsx | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

       via  03d930ad4e5cd9d2a7db243f691e90d4d6fc883a (commit)
      from  927f7b8743df91a181130328857123c72e52ebd2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 03d930ad4e5cd9d2a7db243f691e90d4d6fc883a
Author: Stephen Smith <stephen at curii.com>
Date:   Fri Sep 30 10:41:55 2022 -0400

    16073: Add min width to process io preview label column
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/src/views/process-panel/process-io-card.tsx b/src/views/process-panel/process-io-card.tsx
index 7284159e..84a9ca6d 100644
--- a/src/views/process-panel/process-io-card.tsx
+++ b/src/views/process-panel/process-io-card.tsx
@@ -82,7 +82,8 @@ type CssRules =
   | "halfRow"
   | "symmetricTabs"
   | "imagePlaceholder"
-  | "rowWithPreview";
+  | "rowWithPreview"
+  | "labelColumn";
 
 const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
     card: {
@@ -183,7 +184,10 @@ const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
     },
     rowWithPreview: {
         verticalAlign: 'bottom',
-    }
+    },
+    labelColumn: {
+        minWidth: '120px',
+    },
 });
 
 export enum ProcessIOCardType {
@@ -328,7 +332,7 @@ const ProcessIOPreview = withStyles(styles)(
             <TableHead>
                 <TableRow>
                     <TableCell>Name</TableCell>
-                    {showLabel && <TableCell>Label</TableCell>}
+                    {showLabel && <TableCell className={classes.labelColumn}>Label</TableCell>}
                     <TableCell>Value</TableCell>
                     <TableCell>Collection</TableCell>
                 </TableRow>
@@ -390,11 +394,6 @@ const ProcessValuePreview = withStyles(styles)(
         </Typography>
 )
 
-const handleClick = (url) => {
-    window.open(url, '_blank');
-}
-
-
 interface ProcessIORawDataProps {
     data: ProcessIOParameter[];
 }
@@ -591,7 +590,7 @@ const KeepUrlPath = withStyles(styles)(({auth, res, pdh, classes}: KeepUrlProps
 
     const keepUrlPathNav = getKeepNavUrl(auth, res, pdh);
     return keepUrlPath && keepUrlPathNav ?
-        <Tooltip title={"View in keep-web"}><a className={classes.keepLink} href={keepUrlPathNav} target="_blank">{keepUrlPath}</a></Tooltip> :
+        <Tooltip title={"View in keep-web"}><a className={classes.keepLink} href={keepUrlPathNav} target="_blank" rel="noopener noreferrer">{keepUrlPath}</a></Tooltip> :
         // Show No value for root collection io that lacks path part
         <EmptyValue />;
 });

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list