[arvados-workbench2] updated: 2.4.0-325-g35cbda6f
git repository hosting
git at public.arvados.org
Thu Oct 27 12:59:55 UTC 2022
Summary of changes:
src/components/data-explorer/data-explorer.tsx | 4 ++--
src/components/multi-panel-view/multi-panel-view.tsx | 2 +-
src/views/process-panel/process-io-card.tsx | 4 ++--
src/views/process-panel/process-log-card.tsx | 4 ++--
4 files changed, 7 insertions(+), 7 deletions(-)
via 35cbda6f514ee278d512aa15e1191bed7e6cf7a5 (commit)
from a2453ddec7ed7e087dcf522a183f0498d8cba456 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 35cbda6f514ee278d512aa15e1191bed7e6cf7a5
Author: Lucas Di Pentima <lucas.dipentima at curii.com>
Date: Thu Oct 27 09:58:51 2022 -0300
19300: Disables maximiza button instead of hiding it when panel is maximized.
Also, removed the smooth scrolling when selecting a panel, to hopefully
remove the flickering on Firefox.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima at curii.com>
diff --git a/src/components/data-explorer/data-explorer.tsx b/src/components/data-explorer/data-explorer.tsx
index b500ef7c..02532011 100644
--- a/src/components/data-explorer/data-explorer.tsx
+++ b/src/components/data-explorer/data-explorer.tsx
@@ -190,9 +190,9 @@ export const DataExplorer = withStyles(styles)(
<Tooltip title={`Maximize ${panelName || 'panel'}`} disableFocusListener>
<IconButton onClick={doMaximizePanel}><MaximizeIcon /></IconButton>
</Tooltip> }
- { doHidePanel && !panelMaximized &&
+ { doHidePanel &&
<Tooltip title={`Close ${panelName || 'panel'}`} disableFocusListener>
- <IconButton onClick={doHidePanel}><CloseIcon /></IconButton>
+ <IconButton disabled={panelMaximized} onClick={doHidePanel}><CloseIcon /></IconButton>
</Tooltip> }
</Toolbar>
</Grid>
diff --git a/src/components/multi-panel-view/multi-panel-view.tsx b/src/components/multi-panel-view/multi-panel-view.tsx
index 6779bc35..f0cbcf56 100644
--- a/src/components/multi-panel-view/multi-panel-view.tsx
+++ b/src/components/multi-panel-view/multi-panel-view.tsx
@@ -86,7 +86,7 @@ export const MPVPanelContent = ({doHidePanel, doMaximizePanel, doUnMaximizePanel
...props}: MPVPanelContentProps) => {
useEffect(() => {
if (panelRef && panelRef.current) {
- panelRef.current.scrollIntoView({behavior: 'smooth'});
+ panelRef.current.scrollIntoView({alignToTop: true});
}
}, [panelRef]);
diff --git a/src/views/process-panel/process-io-card.tsx b/src/views/process-panel/process-io-card.tsx
index df2f6c51..90427659 100644
--- a/src/views/process-panel/process-io-card.tsx
+++ b/src/views/process-panel/process-io-card.tsx
@@ -276,9 +276,9 @@ export const ProcessIOCard = withStyles(styles)(connect(null, mapDispatchToProps
<Tooltip title={`Maximize ${panelName || 'panel'}`} disableFocusListener>
<IconButton onClick={doMaximizePanel}><MaximizeIcon /></IconButton>
</Tooltip> }
- { doHidePanel && !panelMaximized &&
+ { doHidePanel &&
<Tooltip title={`Close ${panelName || 'panel'}`} disableFocusListener>
- <IconButton onClick={doHidePanel}><CloseIcon /></IconButton>
+ <IconButton disabled={panelMaximized} onClick={doHidePanel}><CloseIcon /></IconButton>
</Tooltip> }
</div>
} />
diff --git a/src/views/process-panel/process-log-card.tsx b/src/views/process-panel/process-log-card.tsx
index 0abb725b..03739699 100644
--- a/src/views/process-panel/process-log-card.tsx
+++ b/src/views/process-panel/process-log-card.tsx
@@ -153,9 +153,9 @@ export const ProcessLogsCard = withStyles(styles)(
<Tooltip title={`Maximize ${panelName || 'panel'}`} disableFocusListener>
<IconButton onClick={doMaximizePanel}><MaximizeIcon /></IconButton>
</Tooltip> }
- { doHidePanel && !panelMaximized &&
+ { doHidePanel &&
<Tooltip title={`Close ${panelName || 'panel'}`} disableFocusListener>
- <IconButton onClick={doHidePanel}><CloseIcon /></IconButton>
+ <IconButton disabled={panelMaximized} onClick={doHidePanel}><CloseIcon /></IconButton>
</Tooltip> }
</Grid>}
title={
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list