[arvados] updated: 2.4.0-58-gc3baf127c

git repository hosting git at public.arvados.org
Thu May 26 20:39:52 UTC 2022


Summary of changes:
 cmd/arvados-package/build_test.go | 3 +++
 lib/crunchrun/integration_test.go | 3 +++
 2 files changed, 6 insertions(+)

       via  c3baf127cc6f2e2e93203b1aeaab7586822981dc (commit)
      from  94b8b298c103c711a9e280171f68feb22da584f3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit c3baf127cc6f2e2e93203b1aeaab7586822981dc
Author: Tom Clegg <tom at curii.com>
Date:   Fri May 20 21:27:12 2022 -0400

    Merge branch '15370-docker-tests'
    
    refs #15370
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curii.com>

diff --git a/cmd/arvados-package/build_test.go b/cmd/arvados-package/build_test.go
index 75e8f7604..0f6288360 100644
--- a/cmd/arvados-package/build_test.go
+++ b/cmd/arvados-package/build_test.go
@@ -29,7 +29,10 @@ func (s *BuildSuite) TestBuildAndInstall(c *check.C) {
 		c.Skip("skipping docker tests in short mode")
 	} else if _, err := exec.Command("docker", "info").CombinedOutput(); err != nil {
 		c.Skip("skipping docker tests because docker is not available")
+	} else if os.Getenv("ENABLE_DOCKER_TESTS") == "" {
+		c.Skip("docker tests temporarily disabled if ENABLE_DOCKER_TESTS is not set, see https://dev.arvados.org/issues/15370#note-31")
 	}
+
 	tmpdir := c.MkDir()
 	defer os.RemoveAll(tmpdir)
 	err := os.Chmod(tmpdir, 0755)
diff --git a/lib/crunchrun/integration_test.go b/lib/crunchrun/integration_test.go
index ec0893728..2ba7556cb 100644
--- a/lib/crunchrun/integration_test.go
+++ b/lib/crunchrun/integration_test.go
@@ -249,6 +249,9 @@ func (s *integrationSuite) testRunTrivialContainer(c *C) {
 	if err := exec.Command("which", s.engine).Run(); err != nil {
 		c.Skip(fmt.Sprintf("%s: %s", s.engine, err))
 	}
+	if s.engine == "docker" && os.Getenv("ENABLE_DOCKER_TESTS") == "" {
+		c.Skip("docker tests temporarily disabled if ENABLE_DOCKER_TESTS is not set, see https://dev.arvados.org/issues/15370#note-31")
+	}
 	s.cr.Command = []string{"sh", "-c", "cat /mnt/in/inputfile >/mnt/out/inputfile && cat /mnt/json >/mnt/out/json && ! touch /mnt/in/shouldbereadonly && mkdir /mnt/out/emptydir"}
 	s.setup(c)
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list