[arvados] updated: 2.1.0-2747-gfa502f761

git repository hosting git at public.arvados.org
Fri Jul 15 16:04:24 UTC 2022


Summary of changes:
 lib/diagnostics/cmd.go | 7 +++++++
 1 file changed, 7 insertions(+)

       via  fa502f7616688af482e614e1a30cd6dd341e2dec (commit)
      from  4a9acc11eaba55a152851256d19c8fdad3b9f863 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit fa502f7616688af482e614e1a30cd6dd341e2dec
Author: Tom Clegg <tom at curii.com>
Date:   Fri Jul 15 12:02:48 2022 -0400

    17344: Give up early if cluster config cannot be fetched.
    
    Avoids unhelpful noise, like "unsupported protocol scheme" trying to
    use an empty URL.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at curii.com>

diff --git a/lib/diagnostics/cmd.go b/lib/diagnostics/cmd.go
index ed8d440b8..3455d3307 100644
--- a/lib/diagnostics/cmd.go
+++ b/lib/diagnostics/cmd.go
@@ -134,6 +134,7 @@ func (diag *diagnoser) runtests() {
 
 	var cluster arvados.Cluster
 	cfgpath := "arvados/v1/config"
+	cfgOK := false
 	diag.dotest(20, fmt.Sprintf("getting exported config from https://%s/%s", client.APIHost, cfgpath), func() error {
 		ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(diag.timeout))
 		defer cancel()
@@ -142,6 +143,7 @@ func (diag *diagnoser) runtests() {
 			return err
 		}
 		diag.debugf("Collections.BlobSigning = %v", cluster.Collections.BlobSigning)
+		cfgOK = true
 		return nil
 	})
 
@@ -157,6 +159,11 @@ func (diag *diagnoser) runtests() {
 		return nil
 	})
 
+	if !cfgOK {
+		diag.errorf("cannot proceed without cluster config -- aborting without running any further tests")
+		return
+	}
+
 	// uncomment to create some spurious errors
 	// cluster.Services.WebDAVDownload.ExternalURL.Host = "0.0.0.0:9"
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list