[arvados-workbench2] updated: 2.4.0-159-g62abdd5f

git repository hosting git at public.arvados.org
Tue Jul 12 21:41:03 UTC 2022


Summary of changes:
 src/views/process-panel/process-io-card.tsx    | 29 ++++++++++++++++----------
 src/views/process-panel/process-panel-root.tsx |  2 ++
 2 files changed, 20 insertions(+), 11 deletions(-)

       via  62abdd5fbf51cde6c61350082a7924b3ebaf8526 (commit)
      from  daa412a179a8d7fec006ae21991a1daaffb9fa3d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 62abdd5fbf51cde6c61350082a7924b3ebaf8526
Author: Stephen Smith <stephen at curii.com>
Date:   Tue Jul 12 17:35:59 2022 -0400

    16073: Add default view for empty process IO panels
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/src/views/process-panel/process-io-card.tsx b/src/views/process-panel/process-io-card.tsx
index b9aea931..6f932187 100644
--- a/src/views/process-panel/process-io-card.tsx
+++ b/src/views/process-panel/process-io-card.tsx
@@ -22,9 +22,10 @@ import {
     TableCell,
     Paper,
     Link,
+    Grid,
 } from '@material-ui/core';
 import { ArvadosTheme } from 'common/custom-theme';
-import { CloseIcon, ProcessIcon } from 'components/icon/icon';
+import { CloseIcon, InfoIcon, ProcessIcon } from 'components/icon/icon';
 import { MPVPanelProps } from 'components/multi-panel-view/multi-panel-view';
 import {
   BooleanCommandInputParameter,
@@ -50,6 +51,7 @@ import { File } from 'models/workflow';
 import { getInlineFileUrl } from 'views-components/context-menu/actions/helpers';
 import { AuthState } from 'store/auth/auth-reducer';
 import mime from 'mime';
+import { DefaultView } from 'components/default-view/default-view';
 
 type CssRules = 'card' | 'content' | 'title' | 'header' | 'avatar' | 'iconHeader' | 'tableWrapper' | 'tableRoot' | 'paramValue' | 'keepLink' | 'imagePreview';
 
@@ -135,16 +137,21 @@ export const ProcessIOCard = withStyles(styles)(
                     </div>
                 } />
             <CardContent className={classes.content}>
-                <Tabs value={tabState} onChange={handleChange} variant="fullWidth">
-                    <Tab label="Preview" />
-                    <Tab label="Raw" />
-                </Tabs>
-                {tabState === 0 && <div className={classes.tableWrapper}>
-                    <ProcessIOPreview data={params} />
-                    </div>}
-                {tabState === 1 && <div className={classes.tableWrapper}>
-                    <ProcessIORaw data={raw || params} />
-                    </div>}
+                {params.length ?
+                <div>
+                    <Tabs value={tabState} onChange={handleChange} variant="fullWidth">
+                        <Tab label="Preview" />
+                        <Tab label="Raw" />
+                    </Tabs>
+                    {tabState === 0 && <div className={classes.tableWrapper}>
+                        <ProcessIOPreview data={params} />
+                        </div>}
+                    {tabState === 1 && <div className={classes.tableWrapper}>
+                        <ProcessIORaw data={raw || params} />
+                        </div>}
+                </div> : <Grid container item alignItems='center' justify='center'>
+                    <DefaultView messages={["No parameters found"]} icon={InfoIcon} />
+                </Grid>}
             </CardContent>
         </Card>;
     }
diff --git a/src/views/process-panel/process-panel-root.tsx b/src/views/process-panel/process-panel-root.tsx
index e130054b..3447dc2a 100644
--- a/src/views/process-panel/process-panel-root.tsx
+++ b/src/views/process-panel/process-panel-root.tsx
@@ -85,6 +85,8 @@ export const ProcessPanelRoot = withStyles(styles)(
     React.useEffect(() => {
         if (outputDetails.rawOutputs) {
             setProcessedOutputs(formatOutputData(outputDetails.rawOutputs, outputDetails.pdh, auth));
+        } else {
+            setProcessedOutputs([]);
         }
     }, [outputDetails, auth]);
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list