[arvados-workbench2] updated: 2.4.0-365-g59c625e2

git repository hosting git at public.arvados.org
Thu Dec 8 14:24:28 UTC 2022


Summary of changes:
 src/components/breadcrumbs/breadcrumbs.tsx              | 17 ++++++++++++++---
 .../main-content-bar/main-content-bar.tsx               |  7 +++++--
 2 files changed, 19 insertions(+), 5 deletions(-)

       via  59c625e23ea98288ed11674f6218b998fc807307 (commit)
       via  c013d74df98309f7cc57fd854bfd8e35634cba67 (commit)
      from  3d4803244cc4fd2135ab6f75f527a720ef9eee4e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 59c625e23ea98288ed11674f6218b998fc807307
Author: Stephen Smith <stephen at curii.com>
Date:   Wed Dec 7 18:53:20 2022 -0500

    19504: Set breadcrumbs chevron color to match icon
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/src/components/breadcrumbs/breadcrumbs.tsx b/src/components/breadcrumbs/breadcrumbs.tsx
index c887727e..baf84d1d 100644
--- a/src/components/breadcrumbs/breadcrumbs.tsx
+++ b/src/components/breadcrumbs/breadcrumbs.tsx
@@ -19,7 +19,7 @@ export interface Breadcrumb {
     uuid: string;
 }
 
-type CssRules = "item" | "label" | "buttonLabel" | "icon" | "frozenIcon";
+type CssRules = "item" | "chevron" | "label" | "buttonLabel" | "icon" | "frozenIcon";
 
 const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
     item: {
@@ -31,6 +31,9 @@ const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
             color: `${theme.palette.primary.main}`,
         },
     },
+    chevron: {
+        color: grey["600"],
+    },
     label: {
         textTransform: "none",
         paddingRight: '3px',
@@ -101,7 +104,7 @@ export const Breadcrumbs = withStyles(styles)(
                             }
                         </Button>
                     </Tooltip>
-                    {!isLastItem && <ChevronRightIcon color="inherit" className={'parentItem'} />}
+                    {!isLastItem && <ChevronRightIcon color="inherit" className={classNames('parentItem', classes.chevron)} />}
                 </React.Fragment>
             );
         })

commit c013d74df98309f7cc57fd854bfd8e35634cba67
Author: Stephen Smith <stephen at curii.com>
Date:   Wed Dec 7 18:46:59 2022 -0500

    19504: Allow breadcrumbs to collapse to icons instead of wrapping
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/src/components/breadcrumbs/breadcrumbs.tsx b/src/components/breadcrumbs/breadcrumbs.tsx
index 1d4b7b27..c887727e 100644
--- a/src/components/breadcrumbs/breadcrumbs.tsx
+++ b/src/components/breadcrumbs/breadcrumbs.tsx
@@ -19,12 +19,13 @@ export interface Breadcrumb {
     uuid: string;
 }
 
-type CssRules = "item" | "label" | "icon" | "frozenIcon";
+type CssRules = "item" | "label" | "buttonLabel" | "icon" | "frozenIcon";
 
 const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
     item: {
         borderRadius: '16px',
         height: '32px',
+        minWidth: '36px',
         color: theme.customs.colors.grey700,
         '&.parentItem': {
             color: `${theme.palette.primary.main}`,
@@ -36,6 +37,10 @@ const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
         paddingLeft: '3px',
         lineHeight: '1.4',
     },
+    buttonLabel: {
+        overflow: 'hidden',
+        justifyContent: 'flex-start',
+    },
     icon: {
         fontSize: 20,
         color: grey["600"],
@@ -57,7 +62,7 @@ export interface BreadcrumbsProps {
 
 export const Breadcrumbs = withStyles(styles)(
     ({ classes, onClick, onContextMenu, items, resources }: BreadcrumbsProps & WithStyles<CssRules>) =>
-    <Grid container data-cy='breadcrumbs' alignItems="center">
+    <Grid container data-cy='breadcrumbs' alignItems="center" wrap="nowrap">
     {
         items.map((item, index) => {
             const isLastItem = index === items.length - 1;
@@ -78,6 +83,9 @@ export const Breadcrumbs = withStyles(styles)(
                                 isLastItem ? null : 'parentItem',
                                 classes.item
                             )}
+                            classes={{
+                                label: classes.buttonLabel
+                            }}
                             color="inherit"
                             onClick={() => onClick(item)}
                             onContextMenu={event => onContextMenu(event, item)}>
diff --git a/src/views-components/main-content-bar/main-content-bar.tsx b/src/views-components/main-content-bar/main-content-bar.tsx
index 5c1bec90..3f4de301 100644
--- a/src/views-components/main-content-bar/main-content-bar.tsx
+++ b/src/views-components/main-content-bar/main-content-bar.tsx
@@ -15,12 +15,15 @@ import RefreshButton from "components/refresh-button/refresh-button";
 import { loadSidePanelTreeProjects } from "store/side-panel-tree/side-panel-tree-actions";
 import { Dispatch } from "redux";
 
-type CssRules = 'mainBar' | 'infoTooltip';
+type CssRules = 'mainBar' | 'breadcrumbContainer' | 'infoTooltip';
 
 const styles: StyleRulesCallback<CssRules> = theme => ({
     mainBar: {
         flexWrap: 'nowrap',
     },
+    breadcrumbContainer: {
+        overflow: 'hidden',
+    },
     infoTooltip: {
         marginTop: '-10px',
         marginLeft: '10px',
@@ -65,7 +68,7 @@ const mapDispatchToProps = () => (dispatch: Dispatch) => ({
 export const MainContentBar = connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(
     (props: MainContentBarProps & WithStyles<CssRules> & any) =>
         <Toolbar><Grid container className={props.classes.mainBar}>
-            <Grid container item xs alignItems="center">
+            <Grid container item xs alignItems="center" className={props.classes.breadcrumbContainer}>
                 <Breadcrumbs />
             </Grid>
             <Grid item>

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list