[ARVADOS] created: 2.1.0-2335-g0ceaaf049
Git user
git at public.arvados.org
Fri Apr 15 17:53:12 UTC 2022
at 0ceaaf049f7042e54ccdafaded9fa4f7de4bdb8b (commit)
commit 0ceaaf049f7042e54ccdafaded9fa4f7de4bdb8b
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 13:28:09 2022 -0400
18995: add scope to all <th> tags that are missing one.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/apps/workbench/app/views/projects/_compute_node_summary.html.erb b/apps/workbench/app/views/projects/_compute_node_summary.html.erb
index 40a212e5b..474fc7b9f 100644
--- a/apps/workbench/app/views/projects/_compute_node_summary.html.erb
+++ b/apps/workbench/app/views/projects/_compute_node_summary.html.erb
@@ -13,8 +13,8 @@ SPDX-License-Identifier: AGPL-3.0 %>
<td><%= nodes.select {|n| n.crunch_worker_state == "idle" }.size %></td>
</tr>
<tr>
- <th>Busy nodes</th>
- <th>Idle nodes</th>
+ <th scope="col">Busy nodes</th>
+ <th scope="col">Idle nodes</th>
</tr>
</table>
</div>
diff --git a/apps/workbench/app/views/projects/_container_summary.html.erb b/apps/workbench/app/views/projects/_container_summary.html.erb
index 2df4d81c0..c40ee370b 100644
--- a/apps/workbench/app/views/projects/_container_summary.html.erb
+++ b/apps/workbench/app/views/projects/_container_summary.html.erb
@@ -9,8 +9,8 @@ SPDX-License-Identifier: AGPL-3.0 %>
<col width="50%">
</colgroup>
<tr>
- <th>Pending containers</th>
- <th>Running containers</th>
+ <th scope="col">Pending containers</th>
+ <th scope="col">Running containers</th>
</tr>
<tr>
<% pending_containers = Container.order("created_at asc").filter([["state", "in", ["Queued", "Locked"]], ["priority", ">", 0]]).limit(1) %>
@@ -19,8 +19,8 @@ SPDX-License-Identifier: AGPL-3.0 %>
<td><%= running_containers.items_available %></td>
</tr>
<tr>
- <th>Oldest pending</th>
- <th>Longest running</th>
+ <th scope="col">Oldest pending</th>
+ <th scope="col">Longest running</th>
</tr>
<tr>
<td><% if pending_containers.first then %>
diff --git a/apps/workbench/app/views/users/activity.html.erb b/apps/workbench/app/views/users/activity.html.erb
index 9df4b1fce..64be1ea4a 100644
--- a/apps/workbench/app/views/users/activity.html.erb
+++ b/apps/workbench/app/views/users/activity.html.erb
@@ -24,9 +24,9 @@ table#users-activity-table .cell-for-span-Last-month {
<% end %>
<tr>
- <th rowspan="2">User</th>
+ <th scope="col" rowspan="2">User</th>
<% @spans.each do |span, start_at, end_at| %>
- <th colspan="3" class="cell-for-span-<%= span.gsub ' ','-' %>">
+ <th scope="col" colspan="3" class="cell-for-span-<%= span.gsub ' ','-' %>">
<%= span %>
<br />
<%= start_at.strftime('%b %-d') %>
@@ -37,9 +37,9 @@ table#users-activity-table .cell-for-span-Last-month {
</tr>
<tr>
<% @spans.each do |span, _| %>
- <th class="cell-for-span-<%= span.gsub ' ','-' %>">Logins</th>
- <th class="cell-for-span-<%= span.gsub ' ','-' %>">Jobs</th>
- <th class="cell-for-span-<%= span.gsub ' ','-' %>">Pipelines</th>
+ <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Logins</th>
+ <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Jobs</th>
+ <th scope="col" class="cell-for-span-<%= span.gsub ' ','-' %>">Pipelines</th>
<% end %>
</tr>
diff --git a/apps/workbench/app/views/users/storage.html.erb b/apps/workbench/app/views/users/storage.html.erb
index 151ea8bb9..2a5265c40 100644
--- a/apps/workbench/app/views/users/storage.html.erb
+++ b/apps/workbench/app/views/users/storage.html.erb
@@ -17,21 +17,21 @@ table#users-storage-table .byte-value {
</colgroup>
<tr>
- <th rowspan="2">User</th>
- <th colspan="2">
+ <th scope="col" rowspan="2">User</th>
+ <th scope="col" colspan="2">
Collections Read Size
</th>
- <th colspan="2">
+ <th scope="col" colspan="2">
Collections Persisted Storage
</th>
- <th rowspan="2">Measured At</th>
+ <th scope="col" rowspan="2">Measured At</th>
</tr>
<tr>
<% 2.times do %>
- <th class="byte-value">
+ <th scope="col" class="byte-value">
Total (unweighted)
</th>
- <th class="byte-value">
+ <th scope="col" class="byte-value">
Shared (weighted)
</th>
<% end %>
commit 396ee5851f881e072d0e69ac49e5325ef7a62ff6
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 13:04:54 2022 -0400
18995: add missing <!DOCTYPE>
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/apps/workbench/app/views/virtual_machines/webshell.html.erb b/apps/workbench/app/views/virtual_machines/webshell.html.erb
index bd9c0f0f3..d4f2cd040 100644
--- a/apps/workbench/app/views/virtual_machines/webshell.html.erb
+++ b/apps/workbench/app/views/virtual_machines/webshell.html.erb
@@ -2,6 +2,7 @@
SPDX-License-Identifier: AGPL-3.0 %>
+<!DOCTYPE html>
<html lang="en">
<head>
<title><%= @object.hostname %> / <%= Rails.configuration.Workbench.SiteName %></title>
commit 5dd44f293c340d5c6d1ebb47f8027525bb6c562e
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 13:02:26 2022 -0400
18995: webshell: add missing <head> tag, add missing <title>
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/apps/workbench/app/views/virtual_machines/webshell.html.erb b/apps/workbench/app/views/virtual_machines/webshell.html.erb
index f8b44cef5..bd9c0f0f3 100644
--- a/apps/workbench/app/views/virtual_machines/webshell.html.erb
+++ b/apps/workbench/app/views/virtual_machines/webshell.html.erb
@@ -3,6 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 %>
<html lang="en">
+ <head>
<title><%= @object.hostname %> / <%= Rails.configuration.Workbench.SiteName %></title>
<link rel="stylesheet" href="<%= asset_path 'webshell/styles.css' %>" type="text/css">
<style type="text/css">
diff --git a/apps/workbench/public/webshell/keyboard.html b/apps/workbench/public/webshell/keyboard.html
index 6a95f3b09..271c3f704 100644
--- a/apps/workbench/public/webshell/keyboard.html
+++ b/apps/workbench/public/webshell/keyboard.html
@@ -2,6 +2,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:v="urn:schemas-microsoft-com:vml" xml:lang="en" lang="en">
<head>
+ <title>webshell keyboard</title>
</head>
<body><pre class="box"><div
><i id="27">Esc</i><i id="112">F1</i><i id="113">F2</i><i id="114">F3</i
commit c240206e4fc7dd12bf716b7d8de865c785c1bb60
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 12:58:58 2022 -0400
18995: <html> element should have a language attribute.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/apps/workbench/app/views/collections/show_file_links.html.erb b/apps/workbench/app/views/collections/show_file_links.html.erb
index a82d2556e..d7483a6ab 100644
--- a/apps/workbench/app/views/collections/show_file_links.html.erb
+++ b/apps/workbench/app/views/collections/show_file_links.html.erb
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 %>
<!DOCTYPE html>
-<html>
+<html lang="en">
<% coll_name = "Collection #{@object.uuid}" %>
<% link_opts = {controller: 'collections', action: 'show_file',
uuid: @object.uuid, reader_token: params[:reader_token]} %>
diff --git a/apps/workbench/app/views/layouts/application.html.erb b/apps/workbench/app/views/layouts/application.html.erb
index c0f01da28..93ce59267 100644
--- a/apps/workbench/app/views/layouts/application.html.erb
+++ b/apps/workbench/app/views/layouts/application.html.erb
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 %>
<!DOCTYPE html>
-<html ng-app="Workbench">
+<html lang="en" ng-app="Workbench">
<head>
<meta charset="utf-8">
<title>
diff --git a/apps/workbench/app/views/virtual_machines/webshell.html.erb b/apps/workbench/app/views/virtual_machines/webshell.html.erb
index 735583fae..f8b44cef5 100644
--- a/apps/workbench/app/views/virtual_machines/webshell.html.erb
+++ b/apps/workbench/app/views/virtual_machines/webshell.html.erb
@@ -2,7 +2,7 @@
SPDX-License-Identifier: AGPL-3.0 %>
-<html>
+<html lang="en">
<title><%= @object.hostname %> / <%= Rails.configuration.Workbench.SiteName %></title>
<link rel="stylesheet" href="<%= asset_path 'webshell/styles.css' %>" type="text/css">
<style type="text/css">
diff --git a/apps/workbench/public/404.html b/apps/workbench/public/404.html
index abb9f8039..4454c3969 100644
--- a/apps/workbench/public/404.html
+++ b/apps/workbench/public/404.html
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 -->
<!DOCTYPE html>
-<html>
+<html lang="en">
<head>
<title>The page you were looking for doesn't exist (404)</title>
<style type="text/css">
diff --git a/apps/workbench/public/422.html b/apps/workbench/public/422.html
index faa4a5249..a9fa93a9f 100644
--- a/apps/workbench/public/422.html
+++ b/apps/workbench/public/422.html
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 -->
<!DOCTYPE html>
-<html>
+<html lang="en">
<head>
<title>The change you wanted was rejected (422)</title>
<style type="text/css">
diff --git a/apps/workbench/public/500.html b/apps/workbench/public/500.html
index 97e04f360..3c545fa08 100644
--- a/apps/workbench/public/500.html
+++ b/apps/workbench/public/500.html
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 -->
<!DOCTYPE html>
-<html>
+<html lang="en">
<head>
<title>We're sorry, but something went wrong (500)</title>
<style type="text/css">
diff --git a/apps/workbench/public/graph-example.html b/apps/workbench/public/graph-example.html
index f59303242..ba6d8d169 100644
--- a/apps/workbench/public/graph-example.html
+++ b/apps/workbench/public/graph-example.html
@@ -4,7 +4,7 @@ SPDX-License-Identifier: AGPL-3.0 -->
<!DOCTYPE html>
<!-- from http://bl.ocks.org/1153292 -->
-<html>
+<html lang="en">
<head>
<meta http-equiv="Content-type" content="text/html; charset=utf-8">
<title>Object graph example</title>
diff --git a/services/api/app/views/layouts/application.html.erb b/services/api/app/views/layouts/application.html.erb
index b4f60de34..11d2758ce 100644
--- a/services/api/app/views/layouts/application.html.erb
+++ b/services/api/app/views/layouts/application.html.erb
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 %>
<!DOCTYPE html>
-<html>
+<html lang="en">
<head>
<title>Arvados API Server (<%= Rails.configuration.ClusterID %>)</title>
<%= stylesheet_link_tag "application" %>
diff --git a/services/api/public/404.html b/services/api/public/404.html
index abb9f8039..4454c3969 100644
--- a/services/api/public/404.html
+++ b/services/api/public/404.html
@@ -3,7 +3,7 @@
SPDX-License-Identifier: AGPL-3.0 -->
<!DOCTYPE html>
-<html>
+<html lang="en">
<head>
<title>The page you were looking for doesn't exist (404)</title>
<style type="text/css">
commit 1a0791e2bffcc38b7d05e4a0519c2ba542adb076
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 12:49:31 2022 -0400
18995: remove unused variable (dead code).
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/apps/workbench/app/assets/javascripts/arvados_client.js b/apps/workbench/app/assets/javascripts/arvados_client.js
index 478dc2901..3fe8968ec 100644
--- a/apps/workbench/app/assets/javascripts/arvados_client.js
+++ b/apps/workbench/app/assets/javascripts/arvados_client.js
@@ -15,7 +15,6 @@ function ArvadosClient(arvadosApiToken, arvadosDiscoveryUri) {
return this;
////////////////////////////////
- var that = this;
var promiseDiscovery;
var discoveryDoc;
commit 0ff82bc2ba91e0efb6813d74348267c2320f0ada
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 12:23:06 2022 -0400
18995: use forEach instead of map, not using return value.
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/apps/workbench/app/assets/javascripts/models/session_db.js b/apps/workbench/app/assets/javascripts/models/session_db.js
index fd1cdfe14..70bd0a4ba 100644
--- a/apps/workbench/app/assets/javascripts/models/session_db.js
+++ b/apps/workbench/app/assets/javascripts/models/session_db.js
@@ -173,7 +173,7 @@ window.SessionDB = function() {
// scrub the location bar.
if (document.location.search[0] != '?') { return; }
var params = {};
- document.location.search.slice(1).split('&').map(function(kv) {
+ document.location.search.slice(1).split('&').forEach(function(kv) {
var e = kv.indexOf('=');
if (e < 0) {
return;
@@ -191,7 +191,7 @@ window.SessionDB = function() {
},
fillMissingUUIDs: function() {
var sessions = db.loadAll();
- Object.keys(sessions).map(function(key) {
+ Object.keys(sessions).forEach(function(key) {
if (key.indexOf('://') < 0) {
return;
}
@@ -291,7 +291,7 @@ window.SessionDB = function() {
// a salted token.
migrateNonFederatedSessions: function() {
var sessions = db.loadActive();
- Object.keys(sessions).map(function(uuidPrefix) {
+ Object.keys(sessions).forEach(function(uuidPrefix) {
session = sessions[uuidPrefix];
if (!session.isFromRails && session.token) {
db.saltedToken(uuidPrefix).then(function(saltedToken) {
@@ -310,7 +310,7 @@ window.SessionDB = function() {
var doc = db.discoveryDoc(db.loadLocal());
if (doc === undefined) { return; }
doc.map(function(d) {
- Object.keys(d.remoteHosts).map(function(uuidPrefix) {
+ Object.keys(d.remoteHosts).forEach(function(uuidPrefix) {
if (!(sessions[uuidPrefix])) {
db.findAPI(d.remoteHosts[uuidPrefix]).then(function(baseURL) {
db.login(baseURL, false);
commit ba41412c54cf58f440c642e2ffe17f7c2c7b7ee2
Author: Ward Vandewege <ward at curii.com>
Date: Fri Apr 15 11:51:44 2022 -0400
18995: CSS comments can not use double slash
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/doc/css/nav-list.css b/doc/css/nav-list.css
index 1cc57bc82..3f9873c21 100644
--- a/doc/css/nav-list.css
+++ b/doc/css/nav-list.css
@@ -2,8 +2,8 @@
SPDX-License-Identifier: CC-BY-SA-3.0 */
-// NAV LIST
-// --------
+/* NAV LIST
+ -------- */
.nav-list {
padding-left: 15px;
@@ -34,4 +34,4 @@ SPDX-License-Identifier: CC-BY-SA-3.0 */
.inside-list ul {
list-style-position: inside;
padding-left: 0;
-}
\ No newline at end of file
+}
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list