[ARVADOS] updated: 2.1.0-1484-gb445ae12b

Git user git at public.arvados.org
Fri Oct 8 20:11:26 UTC 2021


Summary of changes:
 sdk/cwl/arvados_cwl/runner.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

       via  b445ae12bc55d0fd6f9b64955e52fcab74207a66 (commit)
      from  eb6b9a3d52cab3f7904bae457a9c210e2a76bf6a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit b445ae12bc55d0fd6f9b64955e52fcab74207a66
Author: Peter Amstutz <peter.amstutz at curii.com>
Date:   Fri Oct 8 16:06:58 2021 -0400

    Fix CWL tests mixed_version_v10_wf and command_input_file_expression
    
    refs #18238
    
    Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz at curii.com>

diff --git a/sdk/cwl/arvados_cwl/runner.py b/sdk/cwl/arvados_cwl/runner.py
index ada64ae69..145f1ad7f 100644
--- a/sdk/cwl/arvados_cwl/runner.py
+++ b/sdk/cwl/arvados_cwl/runner.py
@@ -184,7 +184,10 @@ def set_secondary(fsaccess, builder, inputschema, secondaryspec, primary, discov
             elif isinstance(pattern, dict):
                 specs.append(pattern)
             elif isinstance(pattern, str):
-                specs.append({"pattern": pattern, "required": sf.get("required")})
+                if builder.cwlVersion == "v1.0":
+                    specs.append({"pattern": pattern, "required": True})
+                else:
+                    specs.append({"pattern": pattern, "required": sf.get("required")})
             else:
                 raise SourceLine(primary["secondaryFiles"], i, validate.ValidationException).makeError(
                     "Expression must return list, object, string or null")
@@ -194,6 +197,9 @@ def set_secondary(fsaccess, builder, inputschema, secondaryspec, primary, discov
             if isinstance(sf, dict):
                 if sf.get("class") == "File":
                     pattern = None
+                    if sf.get("location") is None:
+                        raise SourceLine(primary["secondaryFiles"], i, validate.ValidationException).makeError(
+                            "File object is missing 'location': %s" % sf)
                     sfpath = sf["location"]
                     required = True
                 else:

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list