[ARVADOS] updated: 2.1.0-1430-g8cba1fc06

Git user git at public.arvados.org
Mon Oct 4 21:41:02 UTC 2021


Summary of changes:
 sdk/cwl/arvados_cwl/arvdocker.py | 4 +++-
 sdk/cwl/arvados_cwl/arvtool.py   | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

       via  8cba1fc06c937f3c828a55703dad501c28915bda (commit)
      from  e91291c2959c07c9929617e3d080077477a19b33 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 8cba1fc06c937f3c828a55703dad501c28915bda
Author: Peter Amstutz <peter.amstutz at curii.com>
Date:   Mon Oct 4 17:40:40 2021 -0400

    18238: Make sure to pull default image
    
    Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <peter.amstutz at curii.com>

diff --git a/sdk/cwl/arvados_cwl/arvdocker.py b/sdk/cwl/arvados_cwl/arvdocker.py
index 3c8208271..26408317c 100644
--- a/sdk/cwl/arvados_cwl/arvdocker.py
+++ b/sdk/cwl/arvados_cwl/arvdocker.py
@@ -49,8 +49,10 @@ def arv_docker_get_image(api_client, dockerRequirement, pull_image, project_uuid
         if not images:
             # Fetch Docker image if necessary.
             try:
-                cwltool.docker.DockerCommandLineJob.get_image(dockerRequirement, pull_image,
+                result = cwltool.docker.DockerCommandLineJob.get_image(dockerRequirement, pull_image,
                                                               force_pull, tmp_outdir_prefix)
+                if not result:
+                    raise WorkflowException("Docker image '%s' not available" % dockerRequirement["dockerImageId"])
             except OSError as e:
                 raise WorkflowException("While trying to get Docker image '%s', failed to execute 'docker': %s" % (dockerRequirement["dockerImageId"], e))
 
diff --git a/sdk/cwl/arvados_cwl/arvtool.py b/sdk/cwl/arvados_cwl/arvtool.py
index 83648f46a..b66e8ad3a 100644
--- a/sdk/cwl/arvados_cwl/arvtool.py
+++ b/sdk/cwl/arvados_cwl/arvtool.py
@@ -62,7 +62,7 @@ class ArvadosCommandTool(CommandLineTool):
         (docker_req, docker_is_req) = self.get_requirement("DockerRequirement")
         if not docker_req:
             self.hints.append({"class": "DockerRequirement",
-                               "dockerImageId": "arvados/jobs:"+__version__})
+                               "dockerPull": "arvados/jobs:"+__version__})
 
         self.arvrunner = arvrunner
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list