[ARVADOS-WORKBENCH2] updated: 2.3.0-35-ge8bcd67b

Git user git at public.arvados.org
Mon Nov 22 14:17:50 UTC 2021


Summary of changes:
 .../multi-panel-view/multi-panel-view.test.tsx         | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

       via  e8bcd67bb51181baa6ce9b16f066e32f51574dbc (commit)
      from  84e7cf97c86c36ace232896dd997f9a4d25a5f61 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e8bcd67bb51181baa6ce9b16f066e32f51574dbc
Author: Lucas Di Pentima <lucas.dipentima at curii.com>
Date:   Mon Nov 22 11:17:12 2021 -0300

    18128: Fixes unit test due to behavior change.
    
    Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas.dipentima at curii.com>

diff --git a/src/components/multi-panel-view/multi-panel-view.test.tsx b/src/components/multi-panel-view/multi-panel-view.test.tsx
index 53a3bb60..6cf13d78 100644
--- a/src/components/multi-panel-view/multi-panel-view.test.tsx
+++ b/src/components/multi-panel-view/multi-panel-view.test.tsx
@@ -22,7 +22,7 @@ describe('<MPVContainer />', () => {
         };
     });
 
-    it('should show default toggle buttons for every child', () => {
+    it('should show default panel buttons for every child', () => {
         const childs = [
             <PanelMock key={1}>This is one panel</PanelMock>,
             <PanelMock key={2}>This is another panel</PanelMock>,
@@ -34,25 +34,27 @@ describe('<MPVContainer />', () => {
         expect(wrapper.html()).toContain('This is another panel');
     });
 
-    it('should toggle panel when clicking on its button', () => {
+    it('should show panel when clicking on its button', () => {
         const childs = [
             <PanelMock key={1}>This is one panel</PanelMock>,
         ];
-        const wrapper = mount(<MPVContainer {...props}>{[...childs]}</MPVContainer>);
+        props.panelStates = [
+            {name: 'Initially invisible Panel', visible: false},
+        ]
 
-        // Initial state: panel visible
-        expect(wrapper.html()).toContain('This is one panel');
+        const wrapper = mount(<MPVContainer {...props}>{[...childs]}</MPVContainer>);
 
-        // Panel toggling
-        wrapper.find(Button).simulate('click');
+        // Initial state: panel not visible
         expect(wrapper.html()).not.toContain('This is one panel');
         expect(wrapper.html()).toContain('All panels are hidden');
+
+        // Panel visible when clicking on its button
         wrapper.find(Button).simulate('click');
         expect(wrapper.html()).toContain('This is one panel');
         expect(wrapper.html()).not.toContain('All panels are hidden');
     });
 
-    it('should show custom toggle buttons when config provided', () => {
+    it('should show custom panel buttons when config provided', () => {
         const childs = [
             <PanelMock key={1}>This is one panel</PanelMock>,
             <PanelMock key={2}>This is another panel</PanelMock>,

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list