[ARVADOS-WORKBENCH2] updated: 2.2.1-122-gfd716454

Git user git at public.arvados.org
Tue Nov 9 19:30:11 UTC 2021


Summary of changes:
 src/views/group-details-panel/group-details-panel.tsx | 8 ++++----
 src/views/groups-panel/groups-panel.tsx               | 5 +----
 2 files changed, 5 insertions(+), 8 deletions(-)

       via  fd716454af93ebe1beb5b138020eb8d407505e38 (commit)
      from  f3266a6f4b6892a8e817c0d04f693ee8911ab49c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit fd716454af93ebe1beb5b138020eb8d407505e38
Author: Stephen Smith <stephen at curii.com>
Date:   Tue Nov 9 14:29:50 2021 -0500

    18123: Remove unnecessary cick handlers
    
    Arvados-DCO-1.1-Signed-off-by: Stephen Smith <stephen at curii.com>

diff --git a/src/views/group-details-panel/group-details-panel.tsx b/src/views/group-details-panel/group-details-panel.tsx
index 50838f7d..b4a8c6d3 100644
--- a/src/views/group-details-panel/group-details-panel.tsx
+++ b/src/views/group-details-panel/group-details-panel.tsx
@@ -153,8 +153,8 @@ export const GroupDetailsPanel = connect(
                           id={GROUP_DETAILS_MEMBERS_PANEL_ID}
                           onRowClick={noop}
                           onRowDoubleClick={noop}
-                          onContextMenu={this.handleContextMenu}
-                          contextMenuColumn={true}
+                          onContextMenu={noop}
+                          contextMenuColumn={false}
                           hideColumnSelector
                           hideSearchInput
                           actions={
@@ -176,8 +176,8 @@ export const GroupDetailsPanel = connect(
                           id={GROUP_DETAILS_PERMISSIONS_PANEL_ID}
                           onRowClick={noop}
                           onRowDoubleClick={noop}
-                          onContextMenu={this.handleContextMenu}
-                          contextMenuColumn={true}
+                          onContextMenu={noop}
+                          contextMenuColumn={false}
                           hideColumnSelector
                           hideSearchInput
                           paperProps={{
diff --git a/src/views/groups-panel/groups-panel.tsx b/src/views/groups-panel/groups-panel.tsx
index 9bfad524..98dc78ee 100644
--- a/src/views/groups-panel/groups-panel.tsx
+++ b/src/views/groups-panel/groups-panel.tsx
@@ -62,15 +62,12 @@ const mapStateToProps = (state: RootState) => {
 
 const mapDispatchToProps = {
     onContextMenu: openContextMenu,
-    onRowDoubleClick: (uuid: string) =>
-        navigateToGroupDetails(uuid),
     onNewGroup: openCreateGroupDialog,
 };
 
 export interface GroupsPanelProps {
     onNewGroup: () => void;
     onContextMenu: (event: React.MouseEvent<HTMLElement>, item: any) => void;
-    onRowDoubleClick: (item: string) => void;
     resources: ResourcesState;
 }
 
@@ -84,7 +81,7 @@ export const GroupsPanel = connect(
                 <DataExplorer
                     id={GROUPS_PANEL_ID}
                     onRowClick={noop}
-                    onRowDoubleClick={this.props.onRowDoubleClick}
+                    onRowDoubleClick={noop}
                     onContextMenu={this.handleContextMenu}
                     contextMenuColumn={true}
                     hideColumnSelector

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list