[ARVADOS-WORKBENCH2] created: 2.1.0-370-g084a30a8
Git user
git at public.arvados.org
Wed May 12 14:12:24 UTC 2021
at 084a30a86b46ced0a951c5f3115a0ce4db65434e (commit)
commit 084a30a86b46ced0a951c5f3115a0ce4db65434e
Author: Lucas Di Pentima <lucas at di-pentima.com.ar>
Date: Wed May 12 11:11:14 2021 -0300
17582: Fixes tests by really testing collection naming.
A mistake was made by adding file naming test cases instead of testing
a collection naming operation.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas at di-pentima.com.ar>
diff --git a/cypress/integration/collection.spec.js b/cypress/integration/collection.spec.js
index e9876c97..c6d29b2c 100644
--- a/cypress/integration/collection.spec.js
+++ b/cypress/integration/collection.spec.js
@@ -239,8 +239,6 @@ describe('Collection panel tests', function () {
const names = [
'bar', // initial name already set
- '[between brackets]', // JSON-like strings (#17582)
- '{between braces}', // JSON-like strings (#17582)
'&',
'foo',
'&',
@@ -570,7 +568,8 @@ describe('Collection panel tests', function () {
// Create new collection
cy.get('[data-cy=side-panel-button]').click();
cy.get('[data-cy=side-panel-new-collection]').click();
- const collName = `Test collection (${Math.floor(999999 * Math.random())})`;
+ // Name between brackets tests bugfix #17582
+ const collName = `[Test collection (${Math.floor(999999 * Math.random())})]`;
cy.get('[data-cy=form-dialog]')
.should('contain', 'New collection')
.within(() => {
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list