[ARVADOS-WORKBENCH2] updated: 2.1.0-220-gef1017fb

Git user git at public.arvados.org
Tue Mar 23 13:40:54 UTC 2021


Summary of changes:
 cypress/integration/collection.spec.js | 37 ++++++++++++++++++++--------------
 1 file changed, 22 insertions(+), 15 deletions(-)

       via  ef1017fbad2ff46f5a169bb3fc7d097b5bb746f3 (commit)
      from  8297f0f273e326e64145a48266805b0b3d073c32 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit ef1017fbad2ff46f5a169bb3fc7d097b5bb746f3
Author: Lucas Di Pentima <lucas at di-pentima.com.ar>
Date:   Tue Mar 23 10:40:18 2021 -0300

    17337: Removes only() call, adds failing file rename case.
    
    Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <lucas at di-pentima.com.ar>

diff --git a/cypress/integration/collection.spec.js b/cypress/integration/collection.spec.js
index a85be9d4..ab6a4e97 100644
--- a/cypress/integration/collection.spec.js
+++ b/cypress/integration/collection.spec.js
@@ -170,7 +170,12 @@ describe('Collection panel tests', function () {
         })
     })
 
-    it.only('renames a file using valid names', function () {
+    it('renames a file using valid names', function () {
+        function eachPair(lst, func){
+            for(var i=0; i < lst.length - 1; i++){
+                func(lst[i], lst[i + 1])
+            }
+        }
         // Creates the collection using the admin token so we can set up
         // a bogus manifest text without block signatures.
         cy.createCollection(adminUser.token, {
@@ -182,21 +187,23 @@ describe('Collection panel tests', function () {
                 cy.loginAs(activeUser);
                 cy.doSearch(`${this.testCollection.uuid}`);
 
-                const nameTransitions = [
-                    ['bar', '&'],
-                    ['&', 'foo'],
-                    ['foo', '&'],
-                    ['&', 'I ❤️ ⛵️'],
-                    ['I ❤️ ⛵️', '...'],
-                    ['...', '#..'],
-                    ['#..', 'some name with whitespaces'],
-                    ['some name with whitespaces', 'some name with #2'],
-                    ['some name with #2', 'is this name legal? I hope it is'],
-                    ['is this name legal? I hope it is', 'some_file.pdf#'],
-                    ['some_file.pdf#', 'some_file.pdf?'],
-                    ['some_file.pdf?', '?some_file.pdf']
+                const names = [
+                    'bar', // initial name already set
+                    '&',
+                    'foo',
+                    '&',
+                    'I ❤️ ⛵️',
+                    '...',
+                    '#..',
+                    'some name with whitespaces',
+                    'some name with #2',
+                    'is this name legal? I hope it is',
+                    'some_file.pdf#',
+                    'some_file.pdf?',
+                    '?some_file.pdf',
+                    'some%file.pdf'
                 ];
-                nameTransitions.forEach(([from, to]) => {
+                eachPair(names, (from, to) => {
                     cy.get('[data-cy=collection-files-panel]')
                         .contains(`${from}`).rightclick();
                     cy.get('[data-cy=context-menu]')

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list