[ARVADOS] created: 2.1.0-380-g8a8d51158
Git user
git at public.arvados.org
Thu Feb 4 17:50:36 UTC 2021
at 8a8d51158fcb179c0362c2df2a281c83aca1fceb (commit)
commit 8a8d51158fcb179c0362c2df2a281c83aca1fceb
Author: Javier Bértoli <jbertoli at curii.com>
Date: Thu Feb 4 14:49:47 2021 -0300
fix(tools): remove compute-images scripts' unused parameters
closes #17338
Arvados-DCO-1.1-Signed-off-by: Javier Bértoli <jbertoli at curii.com>
diff --git a/tools/compute-images/arvados-images-aws.json b/tools/compute-images/arvados-images-aws.json
index b83207bd2..6a1c45da2 100644
--- a/tools/compute-images/arvados-images-aws.json
+++ b/tools/compute-images/arvados-images-aws.json
@@ -6,7 +6,6 @@
"build_environment": "aws",
"arvados_cluster": "",
"aws_source_ami": "ami-04d70e069399af2e9",
- "fqdn": "",
"ssh_user": "admin",
"vpc_id": "",
"subnet_id": "",
@@ -75,6 +74,6 @@
"type": "shell",
"execute_command": "sudo -S env {{ .Vars }} /bin/bash '{{ .Path }}'",
"script": "scripts/base.sh",
- "environment_vars": ["ROLE=compute","RESOLVER={{user `resolver`}}","REPOSUFFIX={{user `reposuffix`}}"]
+ "environment_vars": ["RESOLVER={{user `resolver`}}","REPOSUFFIX={{user `reposuffix`}}"]
}]
}
diff --git a/tools/compute-images/arvados-images-azure.json b/tools/compute-images/arvados-images-azure.json
index c8db9499c..a0278d515 100644
--- a/tools/compute-images/arvados-images-azure.json
+++ b/tools/compute-images/arvados-images-azure.json
@@ -14,7 +14,6 @@
"arvados_cluster": "",
"project_id": "",
"account_file": "",
- "fqdn": "",
"resolver": "",
"reposuffix": "",
"public_key_file": ""
@@ -66,6 +65,6 @@
"type": "shell",
"execute_command": "sudo -S env {{ .Vars }} /bin/bash '{{ .Path }}'",
"script": "scripts/base.sh",
- "environment_vars": ["ROLE=compute","RESOLVER={{user `resolver`}}","REPOSUFFIX={{user `reposuffix`}}"]
+ "environment_vars": ["RESOLVER={{user `resolver`}}","REPOSUFFIX={{user `reposuffix`}}"]
}]
}
diff --git a/tools/compute-images/build.sh b/tools/compute-images/build.sh
index 030eb410b..fb02ce944 100755
--- a/tools/compute-images/build.sh
+++ b/tools/compute-images/build.sh
@@ -49,8 +49,6 @@ Options:
Azure SKU image to use
--ssh_user (default: packer)
The user packer will use to log into the image
- --domain (default: arvadosapi.com)
- The domain part of the FQDN for the cluster
--resolver (default: 8.8.8.8)
The dns resolver for the machine
--reposuffix (default: unset)
@@ -78,12 +76,11 @@ AZURE_LOCATION=
AZURE_CLOUD_ENVIRONMENT=
DEBUG=
SSH_USER=
-DOMAIN="arvadosapi.com"
AWS_DEFAULT_REGION=us-east-1
PUBLIC_KEY_FILE=
PARSEDOPTS=$(getopt --name "$0" --longoptions \
- help,json-file:,arvados-cluster-id:,aws-source-ami:,aws-profile:,aws-secrets-file:,aws-region:,aws-vpc-id:,aws-subnet-id:,gcp-project-id:,gcp-account-file:,gcp-zone:,azure-secrets-file:,azure-resource-group:,azure-location:,azure-sku:,azure-cloud-environment:,ssh_user:,domain:,resolver:,reposuffix:,public-key-file:,debug \
+ help,json-file:,arvados-cluster-id:,aws-source-ami:,aws-profile:,aws-secrets-file:,aws-region:,aws-vpc-id:,aws-subnet-id:,gcp-project-id:,gcp-account-file:,gcp-zone:,azure-secrets-file:,azure-resource-group:,azure-location:,azure-sku:,azure-cloud-environment:,ssh_user:,resolver:,reposuffix:,public-key-file:,debug \
-- "" "$@")
if [ $? -ne 0 ]; then
exit 1
@@ -148,9 +145,6 @@ while [ $# -gt 0 ]; do
--ssh_user)
SSH_USER="$2"; shift
;;
- --domain)
- DOMAIN="$2"; shift
- ;;
--resolver)
RESOLVER="$2"; shift
;;
@@ -211,7 +205,6 @@ if [[ ! -z "$AZURE_SECRETS_FILE" ]]; then
source $AZURE_SECRETS_FILE
fi
-FQDN=" -var fqdn=compute.$ARVADOS_CLUSTER_ID.$DOMAIN ";
EXTRA2=""
@@ -264,5 +257,5 @@ if [[ "$PUBLIC_KEY_FILE" != "" ]]; then
EXTRA2+=" -var public_key_file=$PUBLIC_KEY_FILE"
fi
-echo packer build$EXTRA$FQDN -var "role=$role" -var "arvados_cluster=$ARVADOS_CLUSTER_ID"$EXTRA2 $JSON_FILE
-packer build$EXTRA$FQDN -var "role=$role" -var "arvados_cluster=$ARVADOS_CLUSTER_ID"$EXTRA2 $JSON_FILE
+echo packer build$EXTRA -var "arvados_cluster=$ARVADOS_CLUSTER_ID"$EXTRA2 $JSON_FILE
+packer build$EXTRA -var "arvados_cluster=$ARVADOS_CLUSTER_ID"$EXTRA2 $JSON_FILE
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list