[ARVADOS] updated: 2.1.0-623-g43b39915b

[Git user]

Summary of changes:
 lib/crunchrun/container_exec.go | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

       via  43b39915bae3f3c24ab31cfbc7aefdce88f84dcb (commit)
      from  7400a1c821c4bb3a8e3c87e9369da4b72b87c75e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 43b39915bae3f3c24ab31cfbc7aefdce88f84dcb
Author: Nico Cesar <nico at nicocesar.com>
Date:   Thu Apr 8 15:28:04 2021 -0400

    finilizyn interface
    
    Arvados-DCO-1.1-Signed-off-by: Nico Cesar <nico at curii.com>

diff --git a/lib/crunchrun/container_exec.go b/lib/crunchrun/container_exec.go
index 6dc87ec84..809446d73 100644
--- a/lib/crunchrun/container_exec.go
+++ b/lib/crunchrun/container_exec.go
@@ -78,26 +78,25 @@ type ContainerExecuter interface {
 	// - volumes: Now this is ExecOptions.mounts
 	// - hostConfig: Now this is ExecOptions.enableNetwork and others
 	// this are called when StartContainer() is executed.
-	CreateContainer(env []string) error
+	// this will also do any prep work needed to Std*Pipe() to work
+	CreateContainer(env []string, execOptions ExecOptions, containerConfig ContainerConfig) error
 
-	// StartContainer
-	StartContainer(execOptions ExecOptions, containerConfig ContainerConfig) error
-	RemoveContainer() error
+	// StartContainer will start the container little questions asked
+	StartContainer() error
+
+	// Kill the container and optionally remove the underlying image returns an
+	// error if it didn't work (including timeout)
+	Kill() error
 
 	// this is similar how https://golang.org/pkg/os/exec/#Cmd does it.
 	StdinPipe() (io.WriteCloser, error)
 	StdoutPipe() (io.ReadCloser, error)
 	StderrPipe() (io.ReadCloser, error)
 
-	// this is another option
-	Stdin() (io.ReadCloser, error)
-	Stdout() (io.WriteCloser, error)
-	Stderr() (io.WriteCloser, error)
-
 	// Wait for the container to finish
 	Wait()
-	// Kill the container and optionally remove the underlying image
-	Kill(removeImage bool)
+
+	// Returns the exit coui
 	ExitCode() (int, error)
 }
 

-----------------------------------------------------------------------


hooks/post-receive
--