[ARVADOS] updated: 1.3.0-3193-gb15d39ec3

Git user git at public.arvados.org
Tue Sep 22 13:36:39 UTC 2020


Summary of changes:
 services/keep-web/s3_test.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

       via  b15d39ec33dde9639f09bd1aff22fde7806aa24a (commit)
      from  5132075320db7a19e12a5454a70f894c30e917e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit b15d39ec33dde9639f09bd1aff22fde7806aa24a
Author: Tom Clegg <tom at tomclegg.ca>
Date:   Tue Sep 22 09:35:40 2020 -0400

    16809: Expand path-cleaning comment.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at tomclegg.ca>

diff --git a/services/keep-web/s3_test.go b/services/keep-web/s3_test.go
index 94a478f07..9a3989f61 100644
--- a/services/keep-web/s3_test.go
+++ b/services/keep-web/s3_test.go
@@ -313,8 +313,10 @@ func (s *IntegrationSuite) testS3PutObjectFailure(c *check.C, bucket *s3.Bucket,
 	s.testServer.Config.cluster.Collections.S3FolderObjects = false
 
 	// Can't use V4 signature for these tests, because
-	// double-slash is incorrectly cleaned by goamz, resulting in
-	// a "bad signature" error.
+	// double-slash is incorrectly cleaned by the aws.V4Signature,
+	// resulting in a "bad signature" error. (Cleaning the path is
+	// appropriate for other services, but not in S3 where object
+	// names "foo//bar" and "foo/bar" are semantically different.)
 	bucket.S3.Auth = *(aws.NewAuth(arvadostest.ActiveToken, "none", "", time.Now().Add(time.Hour)))
 	bucket.S3.Signature = aws.V2Signature
 

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list