[ARVADOS] updated: 1.3.0-3104-g274ca75e0

Git user git at public.arvados.org
Tue Sep 8 00:25:40 UTC 2020


Summary of changes:
 lib/config/cmd.go                 | 3 +--
 lib/controller/semaphore.go       | 3 +--
 lib/crunchrun/copier.go           | 3 +--
 sdk/go/blockdigest/blockdigest.go | 2 +-
 4 files changed, 4 insertions(+), 7 deletions(-)

       via  274ca75e0b5277d6d591b45e29b1a2c9185bed5a (commit)
      from  1771152da97200b038378666457d18679f4c8cd7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 274ca75e0b5277d6d591b45e29b1a2c9185bed5a
Author: Ward Vandewege <ward at curii.com>
Date:   Mon Sep 7 20:25:25 2020 -0400

    Fix some more golint warnings.
    
    No issue #
    
    Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>

diff --git a/lib/config/cmd.go b/lib/config/cmd.go
index d64106fbc..1ea0883ac 100644
--- a/lib/config/cmd.go
+++ b/lib/config/cmd.go
@@ -161,9 +161,8 @@ func (checkCommand) RunCommand(prog string, args []string, stdin io.Reader, stdo
 
 	if problems {
 		return 1
-	} else {
-		return 0
 	}
+	return 0
 }
 
 func warnAboutProblems(logger logrus.FieldLogger, cfg *arvados.Config) bool {
diff --git a/lib/controller/semaphore.go b/lib/controller/semaphore.go
index ff607bbb5..e1cda33f9 100644
--- a/lib/controller/semaphore.go
+++ b/lib/controller/semaphore.go
@@ -8,7 +8,6 @@ func semaphore(max int) (acquire, release func()) {
 	if max > 0 {
 		ch := make(chan bool, max)
 		return func() { ch <- true }, func() { <-ch }
-	} else {
-		return func() {}, func() {}
 	}
+	return func() {}, func() {}
 }
diff --git a/lib/crunchrun/copier.go b/lib/crunchrun/copier.go
index b1497277f..1b0f168b8 100644
--- a/lib/crunchrun/copier.go
+++ b/lib/crunchrun/copier.go
@@ -195,9 +195,8 @@ func (cp *copier) walkMount(dest, src string, maxSymlinks int, walkMountsBelow b
 	}
 	if walkMountsBelow {
 		return cp.walkMountsBelow(dest, src)
-	} else {
-		return nil
 	}
+	return nil
 }
 
 func (cp *copier) walkMountsBelow(dest, src string) error {
diff --git a/sdk/go/blockdigest/blockdigest.go b/sdk/go/blockdigest/blockdigest.go
index b9ecc45ab..52aa45f85 100644
--- a/sdk/go/blockdigest/blockdigest.go
+++ b/sdk/go/blockdigest/blockdigest.go
@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-// Stores a Block Locator Digest compactly. Can be used as a map key.
+// Package blockdigest stores a Block Locator Digest compactly. Can be used as a map key.
 package blockdigest
 
 import (

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list