[ARVADOS] updated: 1.3.0-3299-g26d877228

Git user git at public.arvados.org
Mon Oct 12 02:12:24 UTC 2020


Summary of changes:
 lib/cmd/cmd.go                    | 2 +-
 sdk/go/auth/auth.go               | 2 +-
 sdk/go/blockdigest/blockdigest.go | 6 +++---
 sdk/go/blockdigest/testing.go     | 2 +-
 sdk/go/keepclient/support.go      | 2 +-
 services/ws/doc.go                | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

       via  26d877228efa7b24e9c266748cf4c5edeafbc3b5 (commit)
      from  7ce1e5122b6e913d90010254009c3c9efc5e1f60 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 26d877228efa7b24e9c266748cf4c5edeafbc3b5
Author: Ward Vandewege <ward at curii.com>
Date:   Sun Oct 11 22:12:12 2020 -0400

    Fix a few more golint warnings.
    
    No issue #
    
    Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>

diff --git a/lib/cmd/cmd.go b/lib/cmd/cmd.go
index 611c95d23..b7d918739 100644
--- a/lib/cmd/cmd.go
+++ b/lib/cmd/cmd.go
@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-// package cmd helps define reusable functions that can be exposed as
+// Package cmd helps define reusable functions that can be exposed as
 // [subcommands of] command line programs.
 package cmd
 
diff --git a/sdk/go/auth/auth.go b/sdk/go/auth/auth.go
index b6a85e05e..f1c2e243b 100644
--- a/sdk/go/auth/auth.go
+++ b/sdk/go/auth/auth.go
@@ -97,7 +97,7 @@ func (a *Credentials) loadTokenFromCookie(r *http.Request) {
 	a.Tokens = append(a.Tokens, string(token))
 }
 
-// LoadTokensFromHTTPRequestBody() loads credentials from the request
+// LoadTokensFromHTTPRequestBody loads credentials from the request
 // body.
 //
 // This is separate from LoadTokensFromHTTPRequest() because it's not
diff --git a/sdk/go/blockdigest/blockdigest.go b/sdk/go/blockdigest/blockdigest.go
index 52aa45f85..ecb09964e 100644
--- a/sdk/go/blockdigest/blockdigest.go
+++ b/sdk/go/blockdigest/blockdigest.go
@@ -15,8 +15,8 @@ import (
 var LocatorPattern = regexp.MustCompile(
 	"^[0-9a-fA-F]{32}\\+[0-9]+(\\+[A-Z][A-Za-z0-9 at _-]*)*$")
 
-// Stores a Block Locator Digest compactly, up to 128 bits.
-// Can be used as a map key.
+// BlockDigest stores a Block Locator Digest compactly, up to 128 bits. Can be
+// used as a map key.
 type BlockDigest struct {
 	H uint64
 	L uint64
@@ -41,7 +41,7 @@ func (w DigestWithSize) String() string {
 	return fmt.Sprintf("%s+%d", w.Digest.String(), w.Size)
 }
 
-// Will create a new BlockDigest unless an error is encountered.
+// FromString creates a new BlockDigest unless an error is encountered.
 func FromString(s string) (dig BlockDigest, err error) {
 	if len(s) != 32 {
 		err = fmt.Errorf("Block digest should be exactly 32 characters but this one is %d: %s", len(s), s)
diff --git a/sdk/go/blockdigest/testing.go b/sdk/go/blockdigest/testing.go
index 7716a71b2..6c7d3bf1e 100644
--- a/sdk/go/blockdigest/testing.go
+++ b/sdk/go/blockdigest/testing.go
@@ -6,7 +6,7 @@
 
 package blockdigest
 
-// Just used for testing when we need some distinct BlockDigests
+// MakeTestBlockDigest is used for testing with distinct BlockDigests
 func MakeTestBlockDigest(i int) BlockDigest {
 	return BlockDigest{L: uint64(i)}
 }
diff --git a/sdk/go/keepclient/support.go b/sdk/go/keepclient/support.go
index 594379b4f..f4e99bdbe 100644
--- a/sdk/go/keepclient/support.go
+++ b/sdk/go/keepclient/support.go
@@ -18,7 +18,7 @@ import (
 	"git.arvados.org/arvados.git/sdk/go/arvadosclient"
 )
 
-// Function used to emit debug messages. The easiest way to enable
+// DebugPrintf emits debug messages. The easiest way to enable
 // keepclient debug messages in your application is to assign
 // log.Printf to DebugPrintf.
 var DebugPrintf = func(string, ...interface{}) {}
diff --git a/services/ws/doc.go b/services/ws/doc.go
index 6a86cbe7a..a67df1511 100644
--- a/services/ws/doc.go
+++ b/services/ws/doc.go
@@ -2,7 +2,7 @@
 //
 // SPDX-License-Identifier: AGPL-3.0
 
-// Arvados-ws exposes Arvados APIs (currently just one, the
+// Package ws exposes Arvados APIs (currently just one, the
 // cache-invalidation event feed at "ws://.../websocket") to
 // websocket clients.
 //

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list