[ARVADOS] updated: 2.1.0-92-g8e60faf42
Git user
git at public.arvados.org
Sun Nov 8 21:41:34 UTC 2020
Summary of changes:
lib/boot/supervisor.go | 6 +++---
lib/controller/api/routable.go | 2 +-
lib/controller/railsproxy/railsproxy.go | 3 +--
sdk/go/arvados/container.go | 4 ++--
services/keepstore/keepstore.go | 4 ++--
5 files changed, 9 insertions(+), 10 deletions(-)
via 8e60faf420f02d750bbaf7792343a95d2c2674ae (commit)
from 17d37d113e9a0636ed8f12aa27bcdc9b04a166fa (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 8e60faf420f02d750bbaf7792343a95d2c2674ae
Author: Ward Vandewege <ward at curii.com>
Date: Sun Nov 8 16:41:21 2020 -0500
Fix more golint warnings.
No issue #
Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <ward at curii.com>
diff --git a/lib/boot/supervisor.go b/lib/boot/supervisor.go
index 3484a1444..1e8e83ff3 100644
--- a/lib/boot/supervisor.go
+++ b/lib/boot/supervisor.go
@@ -438,9 +438,9 @@ func (super *Supervisor) lookPath(prog string) string {
return prog
}
-// Run prog with args, using dir as working directory. If ctx is
-// cancelled while the child is running, RunProgram terminates the
-// child, waits for it to exit, then returns.
+// RunProgram runs prog with args, using dir as working directory. If ctx is
+// cancelled while the child is running, RunProgram terminates the child, waits
+// for it to exit, then returns.
//
// Child's environment will have our env vars, plus any given in env.
//
diff --git a/lib/controller/api/routable.go b/lib/controller/api/routable.go
index 3003ea2df..f88744882 100644
--- a/lib/controller/api/routable.go
+++ b/lib/controller/api/routable.go
@@ -18,7 +18,7 @@ type RoutableFunc func(ctx context.Context, opts interface{}) (interface{}, erro
type RoutableFuncWrapper func(RoutableFunc) RoutableFunc
-// ComposeWrappers(w1, w2, w3, ...) returns a RoutableFuncWrapper that
+// ComposeWrappers (w1, w2, w3, ...) returns a RoutableFuncWrapper that
// composes w1, w2, w3, ... such that w1 is the outermost wrapper.
func ComposeWrappers(wraps ...RoutableFuncWrapper) RoutableFuncWrapper {
return func(f RoutableFunc) RoutableFunc {
diff --git a/lib/controller/railsproxy/railsproxy.go b/lib/controller/railsproxy/railsproxy.go
index ff9de36b7..515dd5df0 100644
--- a/lib/controller/railsproxy/railsproxy.go
+++ b/lib/controller/railsproxy/railsproxy.go
@@ -15,8 +15,7 @@ import (
"git.arvados.org/arvados.git/sdk/go/arvados"
)
-// For now, FindRailsAPI always uses the rails API running on this
-// node.
+// FindRailsAPI always uses the rails API running on this node, for now.
func FindRailsAPI(cluster *arvados.Cluster) (*url.URL, bool, error) {
var best *url.URL
for target := range cluster.Services.RailsAPI.InternalURLs {
diff --git a/sdk/go/arvados/container.go b/sdk/go/arvados/container.go
index 3d08f2235..265944e81 100644
--- a/sdk/go/arvados/container.go
+++ b/sdk/go/arvados/container.go
@@ -32,7 +32,7 @@ type Container struct {
FinishedAt *time.Time `json:"finished_at"` // nil if not yet finished
}
-// Container is an arvados#container resource.
+// ContainerRequest is an arvados#container_request resource.
type ContainerRequest struct {
UUID string `json:"uuid"`
OwnerUUID string `json:"owner_uuid"`
@@ -127,7 +127,7 @@ const (
ContainerStateCancelled = ContainerState("Cancelled")
)
-// ContainerState is a string corresponding to a valid Container state.
+// ContainerRequestState is a string corresponding to a valid Container Request state.
type ContainerRequestState string
const (
diff --git a/services/keepstore/keepstore.go b/services/keepstore/keepstore.go
index f2973b586..3c9d5d15e 100644
--- a/services/keepstore/keepstore.go
+++ b/services/keepstore/keepstore.go
@@ -8,10 +8,10 @@ import (
"time"
)
-// A Keep "block" is 64MB.
+// BlockSize for a Keep "block" is 64MB.
const BlockSize = 64 * 1024 * 1024
-// A Keep volume must have at least MinFreeKilobytes available
+// MinFreeKilobytes is the amount of space a Keep volume must have available
// in order to permit writes.
const MinFreeKilobytes = BlockSize / 1024
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list