[ARVADOS] updated: 1.3.0-2719-gce3903121

[Git user]

Summary of changes:
 lib/pam/pam_arvados.go | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

       via  ce3903121eb9645e99f6f6846de421b9af1bb23f (commit)
      from  876f66bbe9f30e48a45208a627dfd50e2a68ec22 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit ce3903121eb9645e99f6f6846de421b9af1bb23f
Author: Tom Clegg <tom at tomclegg.ca>
Date:   Fri Jun 26 16:28:06 2020 -0400

    15348: Change "no such vm" error message to "permission denied".
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at tomclegg.ca>

diff --git a/lib/pam/pam_arvados.go b/lib/pam/pam_arvados.go
index e9070599c..389033ba9 100644
--- a/lib/pam/pam_arvados.go
+++ b/lib/pam/pam_arvados.go
@@ -128,7 +128,11 @@ func authenticate(logger *logrus.Logger, username, token string, argv []string)
 		return err
 	}
 	if len(vms.Items) == 0 {
-		return fmt.Errorf("no results for hostname %q", hostname)
+		// It's possible there is no VM entry for the
+		// configured hostname, but typically this just means
+		// the user does not have permission to see (let alone
+		// log in to) this VM.
+		return errors.New("permission denied")
 	} else if len(vms.Items) > 1 {
 		return fmt.Errorf("multiple results for hostname %q", hostname)
 	} else if vms.Items[0].Hostname != hostname {

-----------------------------------------------------------------------


hooks/post-receive
--