[ARVADOS] updated: 1.3.0-2640-gbcf8d387a

Git user git at public.arvados.org
Fri Jun 5 15:16:54 UTC 2020


Summary of changes:
 cmd/arvados-server/cmd.go                          |   2 +
 lib/config/load.go                                 |  18 +-
 lib/undelete/cmd.go                                | 316 +++++++++++++++++++++
 lib/undelete/cmd_test.go                           | 117 ++++++++
 .../perms.go => arvados/blob_signature.go}         |  19 +-
 sdk/go/arvados/blob_signature_test.go              |  88 ++++++
 sdk/go/arvados/keep_service.go                     |  38 +++
 sdk/go/keepclient/perms.go                         | 107 +------
 sdk/go/keepclient/perms_test.go                    | 103 -------
 services/keepstore/handler_test.go                 |  51 ++++
 services/keepstore/handlers.go                     |  30 ++
 services/keepstore/volume_test.go                  |   9 +-
 12 files changed, 685 insertions(+), 213 deletions(-)
 create mode 100644 lib/undelete/cmd.go
 create mode 100644 lib/undelete/cmd_test.go
 copy sdk/go/{keepclient/perms.go => arvados/blob_signature.go} (86%)
 create mode 100644 sdk/go/arvados/blob_signature_test.go
 delete mode 100644 sdk/go/keepclient/perms_test.go

       via  bcf8d387aaed911d955e1f26142caba785cd4e07 (commit)
       via  bf277d86fe874fa701c117365ed4c88060b8a984 (commit)
       via  2be95ce7f069d9eb131b0d2d922a5e556f75810c (commit)
       via  f525d01de971b8b06dabc827bc0bbf46ee7ce9cc (commit)
       via  58254d66b4a2c47a7c736c1e7c50203a8cf19805 (commit)
       via  3d80ac6a1ba336ae75fd7afa499d6e0dfd05bff3 (commit)
       via  cff3ee7ddf7caf971bae2850b3a44b9d5142931f (commit)
       via  1c3ce4051e76a877f41485f031c4219d2b732629 (commit)
       via  d9b06eb06c0ac38af922f102da0b8e405bb40f82 (commit)
       via  167e2537365ec68fe6be6a330a2eb698f177aa05 (commit)
       via  f4b5558a5ffca754f15a77446f43aed91ed44dae (commit)
       via  e9fed17eb1a7300d879a74a344dd52b00fb77d6d (commit)
       via  33f8bec994716df827b07bbddb88e5944ff201c1 (commit)
       via  29437a08213a7f295b95d9a14226ab41d98c5148 (commit)
       via  0ad80a1594e583be9821feb8369e8dc4f619ab65 (commit)
       via  74afa26b1ab0349f5a07f0cd88a9ed0e7e5e9545 (commit)
      from  0aec9ab099a57996f52f3c5d120ab0bafde6b2ab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit bcf8d387aaed911d955e1f26142caba785cd4e07
Merge: 0aec9ab09 bf277d86f
Author: Tom Clegg <tom at tomclegg.ca>
Date:   Fri Jun 5 11:16:17 2020 -0400

    Merge branch '16427-undelete'
    
    refs #16427
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at tomclegg.ca>


commit bf277d86fe874fa701c117365ed4c88060b8a984
Author: Tom Clegg <tom at tomclegg.ca>
Date:   Fri Jun 5 11:15:44 2020 -0400

    16427: Update func comments.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at tomclegg.ca>

diff --git a/lib/undelete/cmd.go b/lib/undelete/cmd.go
index cc0ea09ac..09adfae3c 100644
--- a/lib/undelete/cmd.go
+++ b/lib/undelete/cmd.go
@@ -137,9 +137,8 @@ type undeleter struct {
 
 var errNotFound = errors.New("not found")
 
-// Return the timestamp of the newest copy of blk on svc. Second
-// return value is false if blk is not on svc at all, or an error
-// occurs.
+// Finds the timestamp of the newest copy of blk on svc. Returns
+// errNotFound if blk is not on svc at all.
 func (und undeleter) newestMtime(logger logrus.FieldLogger, blk string, svc arvados.KeepService) (time.Time, error) {
 	found, err := svc.Index(und.client, blk)
 	if err != nil {
@@ -161,11 +160,10 @@ func (und undeleter) newestMtime(logger logrus.FieldLogger, blk string, svc arva
 
 var errTouchIneffective = errors.New("(BUG?) touch succeeded but had no effect -- reported timestamp is still too old")
 
-// Ensure the given block exists on the given server and won't be
+// Ensures the given block exists on the given server and won't be
 // eligible for trashing until after our chosen deadline (blobsigexp).
 // Returns an error if the block doesn't exist on the given server, or
-// has an old timestamp and can't be updated.  Reports errors via
-// logger.
+// has an old timestamp and can't be updated.
 //
 // After we decide a block is "safe" (whether or not we had to untrash
 // it), keep-balance might notice that it's currently unreferenced and

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list