[ARVADOS] updated: 1.3.0-2753-g21d95b374

Git user git at public.arvados.org
Tue Jul 7 18:47:46 UTC 2020


Summary of changes:
 lib/ctrlctx/db.go     | 2 +-
 sdk/go/arvados/api.go | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

       via  21d95b374fc204ae021948e70dd8cce264fda05c (commit)
      from  a2b994f10fd73bdd882e691854239fc2d3b2e3a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 21d95b374fc204ae021948e70dd8cce264fda05c
Author: Tom Clegg <tom at tomclegg.ca>
Date:   Tue Jul 7 14:40:08 2020 -0400

    16534: Add/fix comments.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at tomclegg.ca>

diff --git a/lib/ctrlctx/db.go b/lib/ctrlctx/db.go
index e8d9248ff..70e19d7fd 100644
--- a/lib/ctrlctx/db.go
+++ b/lib/ctrlctx/db.go
@@ -66,7 +66,7 @@ type finishFunc func(*error)
 // commit or rollback the transaction, if any.
 //
 //	func example(ctx context.Context) (err error) {
-//		ctx, finishtx := NewContext(ctx, dber)
+//		ctx, finishtx := New(ctx, dber)
 //		defer finishtx(&err)
 //		// ...
 //		tx, err := CurrentTx(ctx)
diff --git a/sdk/go/arvados/api.go b/sdk/go/arvados/api.go
index e97a365ad..295d8137a 100644
--- a/sdk/go/arvados/api.go
+++ b/sdk/go/arvados/api.go
@@ -154,6 +154,12 @@ type LogoutOptions struct {
 	ReturnTo string `json:"return_to"` // Redirect to this URL after logging out
 }
 
+// A RoutableFunc calls an API method (sometimes via a wrapped
+// RoutableFunc) that has real argument types.
+//
+// (It is used by ctrlctx to manage database transactions, so moving
+// it to the router package would cause a circular dependency
+// router->arvadostest->ctrlctx->router.)
 type RoutableFunc func(ctx context.Context, opts interface{}) (interface{}, error)
 
 type API interface {

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list