[ARVADOS] updated: 1.3.0-2836-ga1fca09b0
Git user
git at public.arvados.org
Mon Aug 3 20:09:00 UTC 2020
Summary of changes:
services/api/config/arvados_config.rb | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
discards 6e1e0086e3dbb9c6c55a186ff081df638df25124 (commit)
via a1fca09b01813732e3c3be1127bc6e7bfb0f9f14 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (6e1e0086e3dbb9c6c55a186ff081df638df25124)
\
N -- N -- N (a1fca09b01813732e3c3be1127bc6e7bfb0f9f14)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit a1fca09b01813732e3c3be1127bc6e7bfb0f9f14
Author: medcelerate <32549017+medcelerate at users.noreply.github.com>
Date: Mon Jul 27 13:00:30 2020 -0400
16625: Added fix to prevent ruby from failing when @ appears in the user for the database config.
Added escaping to password and dbname.
refs #16625
Arvados-DCO-1.1-Signed-off-by: Evan Clark <evan.clark.professional at gmail.com>
diff --git a/services/api/config/arvados_config.rb b/services/api/config/arvados_config.rb
index f63f8af03..035a3972f 100644
--- a/services/api/config/arvados_config.rb
+++ b/services/api/config/arvados_config.rb
@@ -16,6 +16,7 @@
# config:migrate to /etc/arvados/config.yml, you will be able to
# delete application.yml and database.yml.
+require "cgi"
require 'config_loader'
require 'open3'
@@ -277,14 +278,16 @@ end
# For config migration, we've previously populated the PostgreSQL
# section of the config from database.yml
#
-ENV["DATABASE_URL"] = "postgresql://#{$arvados_config["PostgreSQL"]["Connection"]["user"]}:"+
- "#{$arvados_config["PostgreSQL"]["Connection"]["password"]}@"+
- "#{dbhost}/#{$arvados_config["PostgreSQL"]["Connection"]["dbname"]}?"+
+database_url = "postgresql://#{CGI.escape $arvados_config["PostgreSQL"]["Connection"]["user"]}:"+
+ "#{CGI.escape $arvados_config["PostgreSQL"]["Connection"]["password"]}@"+
+ "#{dbhost}/#{CGI.escape $arvados_config["PostgreSQL"]["Connection"]["dbname"]}?"+
"template=#{$arvados_config["PostgreSQL"]["Connection"]["template"]}&"+
"encoding=#{$arvados_config["PostgreSQL"]["Connection"]["client_encoding"]}&"+
"collation=#{$arvados_config["PostgreSQL"]["Connection"]["collation"]}&"+
"pool=#{$arvados_config["PostgreSQL"]["ConnectionPool"]}"
+ENV["DATABASE_URL"] = database_url
+
Server::Application.configure do
# Copy into the Rails config object. This also turns Hash into
# OrderedOptions so that application code can use
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list