[ARVADOS] updated: 1.3.0-2459-g7029f0355

Git user git at public.arvados.org
Thu Apr 9 20:59:25 UTC 2020


Summary of changes:
 services/keepstore/command.go | 3 +++
 1 file changed, 3 insertions(+)

       via  7029f0355edfc692b161b656dae5dd6c10c3267d (commit)
      from  4f1152fbdd0506d3d07449bedb2479f2938bcf73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 7029f0355edfc692b161b656dae5dd6c10c3267d
Author: Tom Clegg <tom at tomclegg.ca>
Date:   Thu Apr 9 16:58:36 2020 -0400

    Warn if MaxKeepBlobBuffers > MaxConcurrentRequests.
    
    No issue #
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom at tomclegg.ca>

diff --git a/services/keepstore/command.go b/services/keepstore/command.go
index be2639773..ea08cf977 100644
--- a/services/keepstore/command.go
+++ b/services/keepstore/command.go
@@ -161,6 +161,9 @@ func (h *handler) setup(ctx context.Context, cluster *arvados.Cluster, token str
 		h.Cluster.API.MaxConcurrentRequests = h.Cluster.API.MaxKeepBlobBuffers * 2
 		h.Logger.Warnf("API.MaxConcurrentRequests <1 or not specified; defaulting to MaxKeepBlobBuffers * 2 == %d", h.Cluster.API.MaxConcurrentRequests)
 	}
+	if h.Cluster.API.MaxConcurrentRequests > 0 && h.Cluster.API.MaxConcurrentRequests < h.Cluster.API.MaxKeepBlobBuffers {
+		h.Logger.Warnf("Possible configuration mistake: not useful to set API.MaxKeepBlobBuffers (%d) higher than API.MaxConcurrentRequests (%d)", h.Cluster.API.MaxKeepBlobBuffers, h.Cluster.API.MaxConcurrentRequests)
+	}
 
 	if h.Cluster.Collections.BlobSigningKey != "" {
 	} else if h.Cluster.Collections.BlobSigning {

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list