[ARVADOS] updated: 1.3.0-886-g17cde5d13
Git user
git at public.curoverse.com
Fri May 17 14:42:48 UTC 2019
Summary of changes:
apps/workbench/app/models/arvados_base.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
via 17cde5d1333ae88e9eaf4739e5deaac458a523ec (commit)
via c32ed532a9e300088343f3485a61955901bd14f6 (commit)
from 2e1f0679f116ac77e74dfdc8b1af18f3a633b143 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 17cde5d1333ae88e9eaf4739e5deaac458a523ec
Author: Lucas Di Pentima <ldipentima at veritasgenetics.com>
Date: Fri May 17 11:42:19 2019 -0300
14988: Restores debug message when accessing non-loaded attributes.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima at veritasgenetics.com>
diff --git a/apps/workbench/app/models/arvados_base.rb b/apps/workbench/app/models/arvados_base.rb
index 3f2e0b232..9e3ea46b1 100644
--- a/apps/workbench/app/models/arvados_base.rb
+++ b/apps/workbench/app/models/arvados_base.rb
@@ -123,7 +123,6 @@ class ArvadosBase
else
# Hash, Array
@discovered_columns << column(k, coldef[:type], coldef[:type].constantize.new)
- # serialize k, coldef[:type].constantize
end
attr_reader k
@attribute_info[k] = coldef
@@ -181,6 +180,7 @@ class ArvadosBase
begin
send(attr_name)
rescue
+ Rails.logger.debug "BUG: access non-loaded attribute #{attr_name}"
nil
end
end
commit c32ed532a9e300088343f3485a61955901bd14f6
Author: Lucas Di Pentima <ldipentima at veritasgenetics.com>
Date: Fri May 17 10:28:13 2019 -0300
14988: Fixes destroyed? method to return false on new records.
Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima at veritasgenetics.com>
diff --git a/apps/workbench/app/models/arvados_base.rb b/apps/workbench/app/models/arvados_base.rb
index a25d8ae01..3f2e0b232 100644
--- a/apps/workbench/app/models/arvados_base.rb
+++ b/apps/workbench/app/models/arvados_base.rb
@@ -359,7 +359,7 @@ class ArvadosBase
end
def destroyed?
- !(etag || uuid)
+ !(new_record? || etag || uuid)
end
def destroy
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list