[ARVADOS] updated: 1.3.0-995-g3b004515e

Git user git at public.curoverse.com
Tue Jun 4 18:01:23 UTC 2019


Summary of changes:
 services/api/test/integration/collections_api_test.rb | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

       via  3b004515ed500910533f63cbfd10de28d88ca7f3 (commit)
      from  5ea0a240eb08a4d43d5f7670a694f0158f0bac36 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 3b004515ed500910533f63cbfd10de28d88ca7f3
Author: Tom Clegg <tclegg at veritasgenetics.com>
Date:   Tue Jun 4 14:00:24 2019 -0400

    15306: Adjust tests: check ?include_trash= and avoid paging.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg at veritasgenetics.com>

diff --git a/services/api/test/integration/collections_api_test.rb b/services/api/test/integration/collections_api_test.rb
index 78edbffa6..84eaf24f3 100644
--- a/services/api/test/integration/collections_api_test.rb
+++ b/services/api/test/integration/collections_api_test.rb
@@ -276,19 +276,17 @@ class CollectionsApiTest < ActionDispatch::IntegrationTest
   end
 
   [
+    ["", false],
     ["false", false],
     ["0", false],
     ["true", true],
     ["1", true]
   ].each do |param, truthiness|
-    test "include_trash=#{param} param encoding via query string should be interpreted as include_trash=#{truthiness}" do
+    test "include_trash=#{param.inspect} param encoding via query string should be interpreted as include_trash=#{truthiness}" do
       expired_col = collections(:expired_collection)
       assert expired_col.is_trashed
-      params = {
-        :include_trash => param,
-      }
-      get "/arvados/v1/collections?#{params.to_query}",
-        headers: auth(:active)
+      get("/arvados/v1/collections?include_trash=#{param}",
+          headers: auth(:active))
       assert_response :success
       assert_not_nil json_response['items']
       refute_empty json_response['items']
@@ -302,11 +300,12 @@ class CollectionsApiTest < ActionDispatch::IntegrationTest
     ["true", true],
     ["1", true]
   ].each do |param, truthiness|
-    test "include_trash=#{param} form-encoded param should be interpreted as include_trash=#{truthiness}" do
+    test "include_trash=#{param.inspect} form-encoded param should be interpreted as include_trash=#{truthiness}" do
       expired_col = collections(:expired_collection)
       assert expired_col.is_trashed
       params = [
         ['include_trash', param],
+        ['filters', [['uuid','=',expired_col.uuid]].to_json],
       ]
       get "/arvados/v1/collections",
         params: URI.encode_www_form(params),

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list