[ARVADOS-WORKBENCH2] updated: 1.2.0-1015-g01d6c5f

Git user git at public.curoverse.com
Tue Nov 27 18:05:58 EST 2018


Summary of changes:
 src/models/vocabulary.ts                                              | 4 ++--
 .../resource-properties-form/property-value-field.tsx                 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

       via  01d6c5fbcba3e51ffddf36aa0c5a0be7dc4127bc (commit)
       via  3f2690d796cce718b68006a4005940fa412ddd5f (commit)
      from  8eb3dc9fe8b8ed991b439885f874d5cb5dc1ecd1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 01d6c5fbcba3e51ffddf36aa0c5a0be7dc4127bc
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date:   Wed Nov 28 00:05:42 2018 +0100

    Update getTagValues to handle undefined tag values field
    
    Feature #14393
    
    Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>

diff --git a/src/views-components/resource-properties-form/property-value-field.tsx b/src/views-components/resource-properties-form/property-value-field.tsx
index a9edc80..9df29bd 100644
--- a/src/views-components/resource-properties-form/property-value-field.tsx
+++ b/src/views-components/resource-properties-form/property-value-field.tsx
@@ -75,7 +75,7 @@ const isStrictTag = (tagName: string, vocabulary: Vocabulary) => {
 
 const getTagValues = (tagName: string, vocabulary: Vocabulary) => {
     const tag = vocabulary.tags[tagName];
-    return tag ? tag.values : [];
+    return tag && tag.values ? tag.values : [];
 };
 
 const ITEMS_PLACEHOLDER: string[] = [];

commit 3f2690d796cce718b68006a4005940fa412ddd5f
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date:   Wed Nov 28 00:01:59 2018 +0100

    Mark vocabulary tag fields as optional
    
    Feature #14393
    
    Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>

diff --git a/src/models/vocabulary.ts b/src/models/vocabulary.ts
index 363c177..ea23ad2 100644
--- a/src/models/vocabulary.ts
+++ b/src/models/vocabulary.ts
@@ -10,8 +10,8 @@ export interface Vocabulary {
 }
 
 export interface Tag {
-    strict: boolean;
-    values: string[];
+    strict?: boolean;
+    values?: string[];
 }
 
 const VOCABULARY_VALIDATORS = [

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list