[ARVADOS-WORKBENCH2] updated: 1.2.0-873-g1eb2cc6

Git user git at public.curoverse.com
Wed Nov 14 07:52:53 EST 2018


Summary of changes:
 src/store/details-panel/details-panel-action.ts      | 5 +++--
 src/views-components/details-panel/details-panel.tsx | 4 +---
 2 files changed, 4 insertions(+), 5 deletions(-)

       via  1eb2cc60cbf40d86db2304e11a678c3aa51af321 (commit)
      from  d1231b6ce7e8d40498b15011b88117812acdf632 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 1eb2cc60cbf40d86db2304e11a678c3aa51af321
Author: Pawel Kromplewski <pawel.kromplewski at contractors.roche.com>
Date:   Wed Nov 14 13:52:41 2018 +0100

    Use one const for action and component
    
    Feature #14420
    
    Arvados-DCO-1.1-Signed-off-by: Pawel Kromplewski <pawel.kromplewski at contractors.roche.com>

diff --git a/src/store/details-panel/details-panel-action.ts b/src/store/details-panel/details-panel-action.ts
index ed71716..0f13286 100644
--- a/src/store/details-panel/details-panel-action.ts
+++ b/src/store/details-panel/details-panel-action.ts
@@ -5,6 +5,8 @@
 import { unionize, ofType, UnionOf } from '~/common/unionize';
 import { Dispatch } from 'redux';
 
+export const SLIDE_TIMEOUT = 500;
+
 export const detailsPanelActions = unionize({
     TOGGLE_DETAILS_PANEL: ofType<{}>(),
     LOAD_DETAILS_PANEL: ofType<string>()
@@ -17,9 +19,8 @@ export const loadDetailsPanel = (uuid: string) => detailsPanelActions.LOAD_DETAI
 export const toggleDetailsPanel = () => (dispatch: Dispatch) => {
     // because of material-ui issue resizing details panel breaks tabs.
     // triggering window resize event fixes that.
-    const detailsPanelAnimationDuration = 500;
     setTimeout(() => {
         window.dispatchEvent(new Event('resize'));
-    }, detailsPanelAnimationDuration);
+    }, SLIDE_TIMEOUT);
     dispatch(detailsPanelActions.TOGGLE_DETAILS_PANEL());
 };
diff --git a/src/views-components/details-panel/details-panel.tsx b/src/views-components/details-panel/details-panel.tsx
index 113cf09..fe434b6 100644
--- a/src/views-components/details-panel/details-panel.tsx
+++ b/src/views-components/details-panel/details-panel.tsx
@@ -10,7 +10,6 @@ import { ArvadosTheme } from '~/common/custom-theme';
 import * as classnames from "classnames";
 import { connect } from 'react-redux';
 import { RootState } from '~/store/store';
-import { detailsPanelActions } from "~/store/details-panel/details-panel-action";
 import { CloseIcon } from '~/components/icon/icon';
 import { EmptyResource } from '~/models/empty';
 import { Dispatch } from "redux";
@@ -24,12 +23,11 @@ import { DetailsResource } from "~/models/details";
 import { getResource } from '~/store/resources/resources';
 import { ResourceData } from "~/store/resources-data/resources-data-reducer";
 import { getResourceData } from "~/store/resources-data/resources-data";
-import { toggleDetailsPanel } from '~/store/details-panel/details-panel-action';
+import { toggleDetailsPanel, SLIDE_TIMEOUT } from '~/store/details-panel/details-panel-action';
 
 type CssRules = 'root' | 'container' | 'opened' | 'headerContainer' | 'headerIcon' | 'tabContainer';
 
 const DRAWER_WIDTH = 320;
-const SLIDE_TIMEOUT = 500;
 const styles: StyleRulesCallback<CssRules> = (theme: ArvadosTheme) => ({
     root: {
         background: theme.palette.background.paper,

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list