[ARVADOS-WORKBENCH2] updated: 1.2.0-806-g2253295
Git user
git at public.curoverse.com
Thu Nov 1 17:11:49 EDT 2018
Summary of changes:
.../projects-tree-picker/generic-projects-tree-picker.tsx | 4 ++--
src/views-components/side-panel-tree/side-panel-tree.tsx | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
via 225329559333809ac9b66a008e67211c8f17edec (commit)
from f601bcf1cfeb8779c1cb1418f1f7a4b6a293e59d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
commit 225329559333809ac9b66a008e67211c8f17edec
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date: Thu Nov 1 22:11:37 2018 +0100
Add openOnFirstActivation prop
Feature #14430
Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
diff --git a/src/views-components/projects-tree-picker/generic-projects-tree-picker.tsx b/src/views-components/projects-tree-picker/generic-projects-tree-picker.tsx
index d9e6511..03ff06d 100644
--- a/src/views-components/projects-tree-picker/generic-projects-tree-picker.tsx
+++ b/src/views-components/projects-tree-picker/generic-projects-tree-picker.tsx
@@ -30,7 +30,7 @@ export interface ProjectsTreePickerDataProps {
includeFiles?: boolean;
rootItemIcon: IconType;
showSelection?: boolean;
- openOnActivation?: boolean;
+ openOnFirstActivation?: boolean;
relatedTreePickers?: string[];
loadRootItem: (item: TreeItem<ProjectsTreePickerRootItem>, pickerId: string, includeCollections?: boolean, inlcudeFiles?: boolean) => void;
}
@@ -93,7 +93,7 @@ const mergeToggleItemActive = (
ownProps: ProjectsTreePickerProps
): Partial<PickedTreePickerProps> => ({
toggleItemActive: (event, item, pickerId) => {
- if (ownProps.openOnActivation && !item.active) {
+ if (ownProps.openOnFirstActivation && item.status === TreeItemStatus.INITIAL) {
dispatchProps.toggleItemOpen(event, item, pickerId);
}
dispatchProps.toggleItemActive(event, item, pickerId);
diff --git a/src/views-components/side-panel-tree/side-panel-tree.tsx b/src/views-components/side-panel-tree/side-panel-tree.tsx
index 8214624..6aa1743 100644
--- a/src/views-components/side-panel-tree/side-panel-tree.tsx
+++ b/src/views-components/side-panel-tree/side-panel-tree.tsx
@@ -20,8 +20,8 @@ export type SidePanelTreesProps = Pick<ProjectsTreePickerProps, 'toggleItemActiv
export const SidePanelTrees = (props: SidePanelTreesProps) =>
<div>
- <HomeTreePicker pickerId={SidePanelTreeId.HOME} openOnActivation {...{ relatedTreePickers }} {...props} />
- <SharedTreePicker pickerId={SidePanelTreeId.SHARED} openOnActivation {...{ relatedTreePickers }} {...props} />
+ <HomeTreePicker pickerId={SidePanelTreeId.HOME} openOnFirstActivation {...{ relatedTreePickers }} {...props} />
+ <SharedTreePicker pickerId={SidePanelTreeId.SHARED} openOnFirstActivation {...{ relatedTreePickers }} {...props} />
<WorkflowsTreePicker pickerId={SidePanelTreeId.WORKFLOWS} {...{ relatedTreePickers }} {...props} />
<RecentTreePicker pickerId={SidePanelTreeId.RECENT} {...{ relatedTreePickers }} {...props} />
<FavoritesTreePicker pickerId={SidePanelTreeId.FAVORITES} {...{ relatedTreePickers }} {...props} />
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list