[ARVADOS-WORKBENCH2] created: 1.1.4-270-ge64e1fa
Git user
git at public.curoverse.com
Thu Jul 12 05:17:02 EDT 2018
at e64e1fad0a7dfc9be07c7e62a542af8762816c01 (commit)
commit e64e1fad0a7dfc9be07c7e62a542af8762816c01
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date: Thu Jul 12 11:16:47 2018 +0200
Remove unnecessary navigation operations
Feature #13746
Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
diff --git a/src/store/navigation/navigation-action.ts b/src/store/navigation/navigation-action.ts
index 1cab734..7ba245a 100644
--- a/src/store/navigation/navigation-action.ts
+++ b/src/store/navigation/navigation-action.ts
@@ -37,12 +37,6 @@ export const setProjectItem = (itemId: string, itemMode: ItemMode) =>
if (treeItem) {
- dispatch(sidePanelActions.RESET_SIDE_PANEL_ACTIVITY());
- const projectsItem = sidePanelData[0];
- if(sidePanel.some(item => item.id === projectsItem.id && !item.open)){
- dispatch(sidePanelActions.TOGGLE_SIDE_PANEL_ITEM_OPEN(projectsItem.id));
- }
-
if (itemMode === ItemMode.OPEN || itemMode === ItemMode.BOTH) {
dispatch(projectActions.TOGGLE_PROJECT_TREE_ITEM_OPEN(treeItem.data.uuid));
}
commit 518813ad4b81d9ebe7b858a28b0fbe7116f5e0bd
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date: Thu Jul 12 11:15:54 2018 +0200
Create new state on PROJECT_REQUEST action
Feature #13746
Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
diff --git a/src/store/project/project-reducer.ts b/src/store/project/project-reducer.ts
index 83aa5b9..5693fb6 100644
--- a/src/store/project/project-reducer.ts
+++ b/src/store/project/project-reducer.ts
@@ -126,7 +126,7 @@ const projectsReducer = (state: ProjectState = initialState, action: ProjectActi
item.status = TreeItemStatus.Pending;
state.items = items;
}
- return state;
+ return { ...state, items };
},
PROJECTS_SUCCESS: ({ projects, parentItemId }) => {
const items = _.cloneDeep(state.items);
commit 89faf6947380e01a18211579c2dc59a2233ee13b
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date: Thu Jul 12 11:06:52 2018 +0200
Clone state before updating on PROJECT_SUCCESS
Feature #13746
Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
diff --git a/src/store/project/project-reducer.ts b/src/store/project/project-reducer.ts
index 8ee9e9f..83aa5b9 100644
--- a/src/store/project/project-reducer.ts
+++ b/src/store/project/project-reducer.ts
@@ -129,9 +129,10 @@ const projectsReducer = (state: ProjectState = initialState, action: ProjectActi
return state;
},
PROJECTS_SUCCESS: ({ projects, parentItemId }) => {
+ const items = _.cloneDeep(state.items);
return {
...state,
- items: updateProjectTree(state.items, projects, parentItemId)
+ items: updateProjectTree(items, projects, parentItemId)
};
},
TOGGLE_PROJECT_TREE_ITEM_OPEN: itemId => {
-----------------------------------------------------------------------
hooks/post-receive
--
More information about the arvados-commits
mailing list