[ARVADOS] updated: 1.1.4-585-g436971482

Git user git at public.curoverse.com
Wed Jul 11 09:28:22 EDT 2018


Summary of changes:
 .../app/controllers/work_units_controller.rb       |  29 ++-
 apps/workbench/app/helpers/application_helper.rb   |  13 +-
 apps/workbench/app/helpers/version_helper.rb       |   6 +
 .../views/application/_report_issue_popup.html.erb |   6 +-
 apps/workbench/config/application.default.yml      |   6 +
 apps/workbench/lib/app_version.rb                  |  15 ++
 build/build.list                                   |   1 +
 build/run-tests.sh                                 |   6 +
 doc/_config.yml                                    |   4 +
 .../_container_scheduling_parameters.liquid        |   2 +
 doc/admin/activation.html.textile.liquid           | 229 ++++++++++++++++++++
 doc/admin/spot-instances.html.textile.liquid       |  78 +++++++
 doc/api/methods/groups.html.textile.liquid         |   2 +-
 doc/api/tokens.html.textile.liquid                 |   4 +
 .../arvados-on-kubernetes-GKE.html.textile.liquid  |  62 ++++++
 ...ados-on-kubernetes-minikube.html.textile.liquid |  34 +++
 .../arvados-on-kubernetes.html.textile.liquid      | 133 ++++++++++++
 doc/install/index.html.textile.liquid              |  20 +-
 doc/user/cwl/cwl-extensions.html.textile.liquid    |  23 ++
 lib/cmd/cmd.go                                     |  16 +-
 lib/controller/handler.go                          |   6 +
 lib/controller/handler_test.go                     |   8 +
 lib/dispatchcloud/node_size.go                     |  34 +--
 lib/dispatchcloud/node_size_test.go                |  62 +++---
 sdk/R/R/zzz.R                                      |  10 +
 sdk/R/README.Rmd                                   |   2 +
 sdk/cwl/arvados_cwl/__init__.py                    | 231 +++++++++++----------
 sdk/cwl/arvados_cwl/arv-cwl-schema.yml             |  44 ++++
 sdk/cwl/arvados_cwl/arvcontainer.py                |  80 ++++---
 sdk/cwl/arvados_cwl/arvjob.py                      |  54 +++--
 sdk/cwl/arvados_cwl/arvtool.py                     |  73 +++----
 sdk/cwl/arvados_cwl/arvworkflow.py                 |  69 +++---
 sdk/cwl/arvados_cwl/context.py                     |  33 +++
 sdk/cwl/arvados_cwl/crunch_script.py               |  19 +-
 sdk/cwl/arvados_cwl/done.py                        |  10 +-
 sdk/cwl/arvados_cwl/pathmapper.py                  |  27 ++-
 sdk/cwl/arvados_cwl/runner.py                      |  31 ++-
 sdk/cwl/arvados_cwl/util.py                        |  31 +++
 sdk/cwl/arvados_version.py                         |  17 +-
 sdk/cwl/setup.py                                   |  10 +-
 .../collection_per_tool_packed.cwl                 | 126 +++++++----
 sdk/cwl/tests/makes_intermediates/echo.cwl         |  14 ++
 .../cwl/tests/makes_intermediates/hello1.txt       |   0
 .../tests/makes_intermediates/run_in_single.cwl    |  38 ++++
 sdk/cwl/tests/makes_intermediates/subwf.cwl        |  15 ++
 sdk/cwl/tests/test_container.py                    | 179 ++++++++++------
 sdk/cwl/tests/test_job.py                          | 143 ++++++++-----
 sdk/cwl/tests/test_submit.py                       |  44 +++-
 sdk/cwl/tests/test_util.py                         |  45 ++++
 sdk/cwl/tests/wf/expect_packed.cwl                 | 128 ++++++++----
 ...ubmit_wf.cwl => submit_wf_runner_resources.cwl} |   6 +
 sdk/go/arvados/byte_size.go                        |  91 ++++++++
 sdk/go/arvados/byte_size_test.go                   |  70 +++++++
 sdk/go/arvados/config.go                           |  50 ++++-
 sdk/go/arvados/config_test.go                      |  37 ++++
 sdk/go/arvados/container.go                        |   3 +-
 sdk/python/arvados/__init__.py                     |   2 -
 sdk/python/arvados/api.py                          |   9 +-
 sdk/python/arvados/commands/keepdocker.py          |   2 +-
 sdk/python/arvados/keep.py                         |  19 +-
 sdk/python/arvados/safeapi.py                      |   6 +
 sdk/python/setup.py                                |   1 +
 sdk/python/tests/test_keep_client.py               |  25 +++
 .../controllers/arvados/v1/schema_controller.rb    |   2 +
 .../api/app/models/api_client_authorization.rb     |   3 +-
 services/api/app/models/container_request.rb       |  35 +++-
 services/api/app/models/user.rb                    |   3 +-
 services/api/config/application.default.yml        |  27 ++-
 services/api/lib/app_version.rb                    |  15 ++
 services/api/lib/crunch_dispatch.rb                |   8 +-
 services/api/lib/update_priority.rb                |  25 ++-
 services/api/lib/whitelist_update.rb               |   2 +-
 .../arvados/v1/schema_controller_test.rb           |  14 +-
 services/api/test/integration/remote_user_test.rb  |  33 +++
 services/api/test/unit/container_request_test.rb   |  49 +++--
 services/api/test/unit/update_priority_test.rb     |  30 +++
 services/api/test/unit/user_test.rb                |   4 +-
 .../crunch-dispatch-slurm_test.go                  |  16 +-
 services/crunch-run/crunchrun.go                   |   9 +
 services/crunch-run/crunchrun_test.go              |  22 +-
 .../arvnodeman/computenode/dispatch/slurm.py       |   2 +-
 .../arvnodeman/computenode/driver/ec2.py           |   2 +-
 services/nodemanager/arvnodeman/config.py          |   6 +-
 services/nodemanager/arvnodeman/jobqueue.py        |   6 +-
 services/nodemanager/arvnodeman/nodelist.py        |   2 +-
 services/nodemanager/doc/ec2.example.cfg           |  12 ++
 services/nodemanager/setup.py                      |   4 +-
 services/nodemanager/tests/integration_test.py     |   2 +-
 .../tests/test_computenode_dispatch_slurm.py       |  14 +-
 .../tests/test_computenode_driver_ec2.py           |   4 +-
 services/nodemanager/tests/test_config.py          |  14 +-
 services/nodemanager/tests/test_jobqueue.py        |  12 +-
 services/nodemanager/tests/test_nodelist.py        |   4 +-
 services/nodemanager/tests/testutil.py             |   4 +-
 94 files changed, 2346 insertions(+), 632 deletions(-)
 create mode 100644 doc/admin/activation.html.textile.liquid
 create mode 100644 doc/admin/spot-instances.html.textile.liquid
 create mode 100644 doc/install/arvados-on-kubernetes-GKE.html.textile.liquid
 create mode 100644 doc/install/arvados-on-kubernetes-minikube.html.textile.liquid
 create mode 100644 doc/install/arvados-on-kubernetes.html.textile.liquid
 create mode 100644 sdk/R/R/zzz.R
 create mode 100644 sdk/cwl/arvados_cwl/context.py
 create mode 100644 sdk/cwl/arvados_cwl/util.py
 create mode 100644 sdk/cwl/tests/makes_intermediates/echo.cwl
 copy apps/workbench/app/mailers/.gitkeep => sdk/cwl/tests/makes_intermediates/hello1.txt (100%)
 create mode 100644 sdk/cwl/tests/makes_intermediates/run_in_single.cwl
 create mode 100644 sdk/cwl/tests/makes_intermediates/subwf.cwl
 create mode 100644 sdk/cwl/tests/test_util.py
 copy sdk/cwl/tests/wf/{submit_wf.cwl => submit_wf_runner_resources.cwl} (81%)
 create mode 100644 sdk/go/arvados/byte_size.go
 create mode 100644 sdk/go/arvados/byte_size_test.go
 create mode 100644 sdk/go/arvados/config_test.go
 create mode 100644 services/api/test/unit/update_priority_test.rb

       via  4369714821950366db98a54e4b62fdb5d09951a6 (commit)
       via  be0cdc7814a49fa093b86b698a9756971ba80fcf (commit)
       via  688319dca9cbbb27452a0062943bb38b6935254e (commit)
       via  eead78e2eb11528af8cb862dcb6f9a41737a8a14 (commit)
       via  2c87b580a87a55010da626d352307343f75d6d3a (commit)
       via  e2f50c08c4fc6da7065be222c2620264b521897f (commit)
       via  b478b8a0b4263b0e54060e3fecaab9b6ecdcb085 (commit)
       via  33c10053b22fd5065516eb7df4c58b55a70d490c (commit)
       via  c405f9adab08daa3d4edef9cddd5453a79446c7b (commit)
       via  6dd60d7c70a63ac884515387cd8c92bb97433e1b (commit)
       via  710399e0355ff8ed016a9d3c830730af2e228ad5 (commit)
       via  81fa59a1e7797da8d420a94216bd28031178ae51 (commit)
       via  f339946832e0bb7ad175acaf59733445e6915f7a (commit)
       via  e5a3fb0a69df6c27dc567949a2e64d0e7da65384 (commit)
       via  04c664d6150683e3258168eecc4440a635ef8b16 (commit)
       via  9b16a843a641159867ea390c4c2384b320183b15 (commit)
       via  77cfd1ee241b4a2d408bd3ec5ebc69f34c7496f5 (commit)
       via  d3e2fb85a39562e38ea67f84e9f065815450294a (commit)
       via  b2a50a8539be09b73c5d65719e8eae4b2a15273b (commit)
       via  bd55c808de1d4d25fea7cc047956c45ec9752fa5 (commit)
       via  a8d2a183ac7246bf368d40dba1af226a4968a9c9 (commit)
       via  69138b061aca4e0cbbb7dad080158205f6734e77 (commit)
       via  535856c28a12bb07dc986b980b0f4ccfdfd25640 (commit)
       via  335ee76030e85fa6ac4da79b598cf4c4a212443d (commit)
       via  cd6d6f1f15bc1452a09c16b1a3524b5b289c6100 (commit)
       via  c584cb69cdcfb377deed94745785330562a54ae3 (commit)
       via  3f278cea46034660149403d68e05f0f450330854 (commit)
       via  3a7481703542b0c95d5a23cb45b0d2e7c3ac4c9e (commit)
       via  66c644efeabea073428288378a39a8e988e5b69b (commit)
       via  9b6abcd0448567146b471ad02162d33fd4b1d5a8 (commit)
       via  5c4d9d38dcee73a7ffb6221c80f707c3924da64f (commit)
       via  ee4c01999aff1ebc1e2dc338a70d1d7b812c633c (commit)
       via  380e4da5aab5d24d0e90ea27880974c232538fbf (commit)
       via  a12e4d36901ab3b3027f1168f1ea06b26122829e (commit)
       via  c1ab715afeb9c095efed7e6064ce10021c067c35 (commit)
       via  0695b41ae52b87adcdf49c6411f0da353d7213a9 (commit)
       via  816764a283c2cbf2d41b4582113065922b99bd52 (commit)
       via  8f0815985dfb74fc1c7468426359ac3fbbd8c12d (commit)
       via  1f9519fba9a34f2a596c683ed6395b2e291935b7 (commit)
       via  4a78e8e91fdad38e567fef0cd43aa8cb6bd33580 (commit)
       via  c425f01b6dd63dfe5d99a19f57c8155c2f0fb195 (commit)
       via  3813e892be7f3136e5b14580e7ee64d6c786bf8e (commit)
       via  4a2dc82a1acce855151928abe0030e1dd7dbf728 (commit)
       via  9a9930cebb7f36131490d0f144e23f5066e7f01d (commit)
       via  d128fe6bc8da01fe8e7829db988819dd1c159298 (commit)
       via  76a2c8a1eb1771b5255e8582b7e9823d072e8ef4 (commit)
       via  62f6a306eb965cee6bd814b194bf5ce3bb910116 (commit)
       via  11ab2e23511c7e8962e0110c3aad44b74fea2dbd (commit)
       via  7d4123813b42d8f6478e239895e62f6f600a1c6f (commit)
       via  596884ea30c551d7c2699b2cf3fdea2cede3101a (commit)
       via  bd059862d1dd7e68642dd365f0a536621ff6735f (commit)
       via  0765fb8b19dd7b76ec5d2d05edda3f4fd4347194 (commit)
       via  286f7fb2dbdcd860275a24f3480e938b5bd414ec (commit)
       via  aeaee020e585b69f3fea9381deb0c595eebf7c9a (commit)
       via  32d954c32f20a982bec4b3615bfd7cfca449c280 (commit)
       via  57fd9fa6bf0ee3062d7d38aceb7e97543791d241 (commit)
       via  9df6d2c2152b5b1968649c970664c4f69d9e92e8 (commit)
       via  edf5021cddc7646c920d3c938a2a3b34d6d8c0a5 (commit)
       via  b004059a3372af7aa347ef7b8b73522d489ffec2 (commit)
       via  c90adfb66544a4e6ff34b13268fe3e05847144c2 (commit)
       via  e9e440847c574d1152b128cfd508cf473f49121b (commit)
       via  a4ea40603c5f9c71ce7051fe13e3b493e0829128 (commit)
       via  eed6ea7af40d0d7ee0a11bcb484113bd606f51ed (commit)
       via  ab7bb79f2da9f44eae4b1fd910680ca472b9c5a7 (commit)
       via  ba908bbe90213f1d50422611052c92280eae0dcd (commit)
       via  945258f22c3c02d12e0dada049b8c37fa5139af2 (commit)
       via  a31c1accfc353ed6bb3c9982ee694f98f6c965ec (commit)
       via  42d62e3d140360a179293b8995aaf535e8c4c30c (commit)
       via  059d04053d1a7ac62c796ad5757191b9c5dd5aae (commit)
       via  93661ec76c6c1affcde86563dccda5843a879239 (commit)
       via  7f9465d37fcc3277128d3f4a611b778e24e530a5 (commit)
       via  ebb7681e5cf4bc2825e8786ecda895e219158703 (commit)
       via  6df0096f2b246959bb9449a0940e9c539bcc9100 (commit)
       via  4fdb030e1ad940215b75b4b8a8f7aca5635211e3 (commit)
       via  78a9021dc8baa5603feb512c45c1fbca5f3accfc (commit)
       via  b7acf6db5beab0b082c863fe5a9692d68152a132 (commit)
       via  0bcbbb13f9e278347e500fa344ee600891a9bcb8 (commit)
       via  0e94528878341faa941247eb3d990230c941868c (commit)
       via  645e9829bec9147f52141b17b439f9b561ed3445 (commit)
       via  5d3a682b0fc41f4152051b43b8e5311b9a130f13 (commit)
       via  ec88f99b1eeb811159b3aea9a6f810dc06e9417b (commit)
       via  bd14cd71274109789ea076b1b4219bdf3beef657 (commit)
       via  75f835af6ac337c490a76ac60453242719f6ceca (commit)
       via  905a7305413f57e3188a66fe55d35cecc484b1f2 (commit)
       via  c7414891876cd6d0d02abe71c7376b8104bfbc32 (commit)
       via  a200bee21cc9632428c6ed9e37dd3a4f90682f9d (commit)
       via  731ff645f6de779a324999f3b78bf90469dbb4fb (commit)
       via  9fa635c9dc288317f19471291accecf8690f5718 (commit)
       via  f9e94997cb5c2166d8b71874f263544cfc2fe5ba (commit)
       via  e677e6b27fa35ba2f81a8a35b00fe860926a69ad (commit)
       via  a7cd9cfe43468acd6cbc1b674241fb3c7ffcf0cf (commit)
       via  fa4fc4f452c5b29427512758f4bd14df2fcc3c42 (commit)
       via  cc556a86ae6a83ba4cf5b7125fbabe704207ae60 (commit)
       via  911abf131639401b2ccfd23a6bc3ec983f7ed8f4 (commit)
       via  41e15e626cc301d867c48ebb1f945bbec6b7d555 (commit)
       via  af1978730ccd9bd3584fc1cdace37809eff63a13 (commit)
       via  43e349a8916b4e952dfafee2f88d4d2952be12c1 (commit)
       via  a8bfbac314335eb0bff3f4ff5e856d3c327de31d (commit)
       via  6f1a5b9cb0bc761115ef4bc31472ee47db83a906 (commit)
       via  2538d2a88afa75f4c23961d77fe9ffccb048368a (commit)
       via  5f478e932583f04fc1bd067e437e2d929060dd18 (commit)
       via  519850a6a801553c4cfbc7384236536b5a9cedf2 (commit)
       via  6ac7e6d3d1f75cc6d6fe625d2ceaaf00b86a720d (commit)
       via  bb5b4b99bd9957fd1b4713c5168b0d7e148899ee (commit)
       via  cb97316068f201ffd03f54d67074a83601c2bb45 (commit)
       via  aace3aa52c1b9fe3b2e907f43e8d6801ceeb28f9 (commit)
       via  187d6318298adca84193d8c78952e023f303bc2d (commit)
       via  02763280f54fd0c2a499285f8ce6afcbd8b9e082 (commit)
       via  988c59f51aa579ce8bf0eab1cc729e05a5ee5631 (commit)
       via  088268fc00cb466c4b4576a2dbbaff720cb3e3af (commit)
       via  cdd57a73f2f90d6b14b8652ab94adc14e4b99c8b (commit)
       via  92ac046a8a7a0f5a3a88b8656bb171701af840a0 (commit)
       via  5d340bee3506b37f0d5f0b695dfa37661ad0fbb6 (commit)
      from  73ad2ee9af3b97c46293bdfc9e2925a67726b786 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 4369714821950366db98a54e4b62fdb5d09951a6
Author: Tom Clegg <tclegg at veritasgenetics.com>
Date:   Wed Jul 11 09:27:12 2018 -0400

    13497: 13779: Forward Host header, and don't follow redirects.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg at veritasgenetics.com>

diff --git a/lib/controller/handler.go b/lib/controller/handler.go
index 59c2f2a61..92ded6301 100644
--- a/lib/controller/handler.go
+++ b/lib/controller/handler.go
@@ -47,6 +47,11 @@ func (h *Handler) setup() {
 	})
 	mux.Handle("/", http.HandlerFunc(h.proxyRailsAPI))
 	h.handlerStack = mux
+
+	// Changing the global isn't the right way to do this, but a
+	// proper solution would conflict with an impending 13493
+	// merge anyway, so this will do for now.
+	arvados.InsecureHTTPClient.CheckRedirect = func(*http.Request, []*http.Request) error { return http.ErrUseLastResponse }
 }
 
 // headers that shouldn't be forwarded when proxying. See
@@ -101,6 +106,7 @@ func (h *Handler) proxyRailsAPI(w http.ResponseWriter, reqIn *http.Request) {
 	reqOut := (&http.Request{
 		Method: reqIn.Method,
 		URL:    urlOut,
+		Host:   reqIn.Host,
 		Header: hdrOut,
 		Body:   reqIn.Body,
 	}).WithContext(ctx)
diff --git a/lib/controller/handler_test.go b/lib/controller/handler_test.go
index 981ad7ab9..eb947ea36 100644
--- a/lib/controller/handler_test.go
+++ b/lib/controller/handler_test.go
@@ -120,3 +120,11 @@ func (s *HandlerSuite) TestProxyNotFound(c *check.C) {
 	c.Check(err, check.IsNil)
 	c.Check(jresp["errors"], check.FitsTypeOf, []interface{}{})
 }
+
+func (s *HandlerSuite) TestProxyRedirect(c *check.C) {
+	req := httptest.NewRequest("GET", "https://example.org:1234/login?return_to=foo", nil)
+	resp := httptest.NewRecorder()
+	s.handler.ServeHTTP(resp, req)
+	c.Check(resp.Code, check.Equals, http.StatusFound)
+	c.Check(resp.Header().Get("Location"), check.Matches, `https://example\.org:1234/auth/joshid\?return_to=foo&?`)
+}

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list