[ARVADOS] updated: 1.1.2-50-g8f98248

Git user git at public.curoverse.com
Tue Jan 16 15:19:42 EST 2018


Summary of changes:
 .../app/assets/javascripts/components/edit_tags.js        | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

       via  8f982486f5ed7b49d250fafdf3840a929a824ef7 (commit)
      from  b017ae29973838673d66d9f9da4a07f9852d9476 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 8f982486f5ed7b49d250fafdf3840a929a824ef7
Author: Tom Clegg <tclegg at veritasgenetics.com>
Date:   Tue Jan 16 15:15:43 2018 -0500

    12479: Set dirty flag on change even when clearing input.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg at veritasgenetics.com>

diff --git a/apps/workbench/app/assets/javascripts/components/edit_tags.js b/apps/workbench/app/assets/javascripts/components/edit_tags.js
index 6294bd1..607e215 100644
--- a/apps/workbench/app/assets/javascripts/components/edit_tags.js
+++ b/apps/workbench/app/assets/javascripts/components/edit_tags.js
@@ -176,16 +176,8 @@ window.TagEditorApp = {
         var tag = {name: m.stream(name), value: m.stream(value), rowKey: uniqueID++}
         vnode.state.tags.push(tag)
         // Set dirty flag when any of name/value changes to non empty string
-        tag.name.map(function(v) {
-            if (v !== '') {
-                vnode.state.dirty(true)
-            }
-        })
-        tag.value.map(function(v) {
-            if (v !== '') {
-                vnode.state.dirty(true)
-            }
-        })
+        tag.name.map(function() { vnode.state.dirty(true) })
+        tag.value.map(function() { vnode.state.dirty(true) })
         tag.name.map(m.redraw)
     },
     oninit: function(vnode) {
@@ -213,6 +205,9 @@ window.TagEditorApp = {
                     Object.keys(o.properties).forEach(function(k) {
                         vnode.state.appendTag(vnode, k, o.properties[k])
                     })
+                    if (vnode.state.editMode) {
+                        vnode.state.appendTag(vnode, '', '')
+                    }
                     // Data synced with server, so dirty state should be false
                     vnode.state.dirty(false)
                     // Add new tag row when the last one is completed

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list