[ARVADOS] updated: 1.1.2-43-ge5b7fb1

Git user git at public.curoverse.com
Mon Jan 8 13:08:17 EST 2018


Summary of changes:
 README.md                                          |  14 +-
 .../app/assets/javascripts/components/edit_tags.js |  66 ++++-
 build/check-copyright-notices                      | 301 +++++++++++----------
 build/run-build-docker-jobs-image.sh               |  20 +-
 build/run-build-packages-one-target.sh             |   5 +-
 build/run-library.sh                               |   9 +-
 build/run-tests.sh                                 |   2 +-
 doc/user/cwl/bwa-mem/bwa-mem.cwl                   |   4 +-
 sdk/go/arvados/collection_fs.go                    |   4 +
 sdk/go/arvados/collection_fs_test.go               |  24 ++
 services/crunch-run/crunchrun.go                   |  19 +-
 services/crunch-run/crunchrun_test.go              |   2 +-
 services/crunch-run/logging.go                     |   6 +-
 services/fuse/arvados_fuse/__init__.py             |   5 +-
 services/fuse/tests/test_inodes.py                 |   2 +-
 .../arvados-health.service}                        |  10 +-
 services/keep-web/cadaver_test.go                  |  11 +
 17 files changed, 309 insertions(+), 195 deletions(-)
 copy services/{keepproxy/keepproxy.service => health/arvados-health.service} (68%)

       via  e5b7fb12522636f24d9b23ea587b8d12e13c50c2 (commit)
       via  467722fb20db289fa1eb0833e2d87ee56ed91ba7 (commit)
       via  a5da28efdbc8d9f2673a1b200a14297447b04664 (commit)
       via  cd9b6605e5ad6fb90c531fb4f1c98e113f0498ba (commit)
       via  7bc8466abceb800872bb6f687111f9ebe526e141 (commit)
       via  eae6972da6ffbf73d31fd47138cb49c13fed77de (commit)
       via  456b1c4ef6229c15d80f704647a396da7819139b (commit)
       via  6ac835d8869876955d85a86a4b6d35c12b0d63ac (commit)
       via  13273a566ce37e8426cb851e464ace152d4f02df (commit)
       via  4749f9394bacea3782c701b9bc98f2b9e4995a73 (commit)
       via  987457b7e545f4ad1e32c7a07c00c29c24326421 (commit)
       via  f6d560c1a46b05802ad81dc4a815d28a50c5b8f4 (commit)
       via  5b819f447743fbd8281dcf26143ad556cd710cad (commit)
       via  c152ee1d170bf419ef49241cbde030e8fce68882 (commit)
       via  b3efaa37f1e3c52b5a126ba3416856ceba21549a (commit)
       via  b8ffcc224f73c5c856c6d5993ba06255892a789f (commit)
       via  11377b3b6eb9544b9d9bcabab8de495f6e6fcaa4 (commit)
       via  cf5e73998da0cac4a00d29f6004ea58d11c7acd4 (commit)
       via  08fcef34fae00ecb34d34d4d34dbbb2cec98ced8 (commit)
      from  7ed41dc0191d366c914850a350c3b30f769365af (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit e5b7fb12522636f24d9b23ea587b8d12e13c50c2
Author: Lucas Di Pentima <ldipentima at veritasgenetics.com>
Date:   Mon Jan 8 15:05:53 2018 -0300

    12479: UX enhancements:
    * When focusing a "strict" select list, open the dropdown list
    * Placeholder messages customized for different strict/no-strict cases
    * Added plugin to show a "no results found" message when the user
    types something that doesn't match with the available options on a
    strict list.
    
    Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima at veritasgenetics.com>

diff --git a/apps/workbench/app/assets/javascripts/components/edit_tags.js b/apps/workbench/app/assets/javascripts/components/edit_tags.js
index fa3f13e..583047c 100644
--- a/apps/workbench/app/assets/javascripts/components/edit_tags.js
+++ b/apps/workbench/app/assets/javascripts/components/edit_tags.js
@@ -2,6 +2,60 @@
 //
 // SPDX-License-Identifier: AGPL-3.0
 
+// Plugin taken from: https://gist.github.com/thiago-negri/132bf33b5312e2da823c
+// This behavior seems to be planned to be integrated on the next selectize release
+Selectize.define('no_results', function(options) {
+    var self = this;
+
+    options = $
+        .extend({message: 'No results found.', html: function(data) {
+            return ('<div class="selectize-dropdown ' + data.classNames + ' dropdown-empty-message">' + '<div class="selectize-dropdown-content" style="padding: 3px 12px">' + data.message + '</div>' + '</div>');
+        }}, options);
+
+    self.displayEmptyResultsMessage = function() {
+        this.$empty_results_container.css('top', this.$control.outerHeight());
+        this.$empty_results_container.css('width', this.$control.outerWidth());
+        this.$empty_results_container.show();
+    };
+
+    self.on('type', function(str) {
+        if (str && !self.hasOptions) {
+            self.displayEmptyResultsMessage();
+        } else {
+            self.$empty_results_container.hide();
+        }
+    });
+
+    self.onKeyDown = (function() {
+        var original = self.onKeyDown;
+
+        return function(e) {
+            original.apply(self, arguments);
+            this.$empty_results_container.hide();
+        }
+    })();
+
+    self.onBlur = (function() {
+        var original = self.onBlur;
+
+        return function() {
+            original.apply(self, arguments);
+            this.$empty_results_container.hide();
+        };
+    })();
+
+    self.setup = (function() {
+        var original = self.setup;
+        return function() {
+            original.apply(self, arguments);
+            self.$empty_results_container = $(options.html(
+                $.extend({classNames: self.$input.attr('class')}, options)));
+            self.$empty_results_container.insertBefore(self.$dropdown);
+            self.$empty_results_container.hide();
+        };
+    })();
+});
+
 window.SimpleInput = {
     view: function(vnode) {
         return m("input.form-control", {
@@ -30,7 +84,7 @@ window.SelectOrAutocomplete = {
     onFocus: function(vnode) {
         // Allow the user to edit an already entered value by removing it
         // and filling the input field with the same text
-        activeSelect = vnode.state.selectized[0].selectize
+        var activeSelect = vnode.state.selectized[0].selectize
         value = activeSelect.getValue()
         if (value.length > 0) {
             activeSelect.clear(silent = true)
@@ -48,16 +102,18 @@ window.SelectOrAutocomplete = {
     },
     oncreate: function(vnode) {
         vnode.state.selectized = $(vnode.dom).selectize({
+            plugins: ['no_results'],
             labelField: 'value',
             valueField: 'value',
             searchField: 'value',
             sortField: 'value',
             persist: false,
             hideSelected: true,
-            openOnFocus: false,
+            openOnFocus: !vnode.attrs.create,
             createOnBlur: true,
+            // selectOnTab: true,
             maxItems: 1,
-            placeholder: vnode.attrs.placeholder,
+            placeholder: (vnode.attrs.create ? 'Add or select ': 'Select ') + vnode.attrs.placeholder,
             create: vnode.attrs.create ? function(input) {
                 return {value: input}
             } : false,
@@ -122,7 +178,7 @@ window.TagEditorRow = {
                         value: vnode.attrs.name,
                         // Allow any tag name unless "strict" is set to true.
                         create: !vnode.attrs.vocabulary().strict,
-                        placeholder: 'new tag',
+                        placeholder: 'name',
                         // Focus on tag name field when adding a new tag that's
                         // not the first one.
                         setFocus: vnode.attrs.name() === ''
@@ -137,7 +193,7 @@ window.TagEditorRow = {
                     m(inputComponent, {
                         options: valueOpts,
                         value: vnode.attrs.value,
-                        placeholder: 'new value',
+                        placeholder: 'value',
                         // Allow any value on tags not listed on the vocabulary.
                         // Allow any value on tags without values, or the ones
                         // that aren't explicitly declared to be strict.

commit 467722fb20db289fa1eb0833e2d87ee56ed91ba7
Merge: 7ed41dc a5da28e
Author: Lucas Di Pentima <ldipentima at veritasgenetics.com>
Date:   Mon Jan 8 11:44:38 2018 -0300

    12479: Merge branch 'master' into 12479-wb-structured-vocabulary
    
    Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <ldipentima at veritasgenetics.com>


-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list