[ARVADOS-WORKBENCH2] updated: 1.3.0-295-g15697ab8

Git user git at public.curoverse.com
Mon Dec 31 03:17:54 EST 2018


Summary of changes:
 src/routes/route-change-handlers.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

       via  15697ab8abae3fec197b5750e48342a26daa9557 (commit)
       via  7e31618f7fdc51d797a3bf22524731168de68553 (commit)
      from  4aaf3700eb4d8d15b68a9ad8b220b832e10e1df2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 15697ab8abae3fec197b5750e48342a26daa9557
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date:   Mon Dec 31 09:16:50 2018 +0100

    Set better return type of route handlers ActionCreator
    
    Feature #14653
    
    Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>

diff --git a/src/routes/route-change-handlers.ts b/src/routes/route-change-handlers.ts
index ee48e6da..72b26539 100644
--- a/src/routes/route-change-handlers.ts
+++ b/src/routes/route-change-handlers.ts
@@ -31,7 +31,7 @@ const handleLocationChange = (store: RootStore) => ({ pathname }: Location) => {
 };
 
 type MatchRoute<Params> = (route: string) => match<Params> | null;
-type ActionCreator<Params> = (params: Params) => void;
+type ActionCreator<Params> = (params: Params) => ThunkAction<any, any, any, any>;
 
 const handle = <Params>(matchRoute: MatchRoute<Params>, actionCreator: ActionCreator<Params>) =>
     (dispatch: Dispatch, route: string) => {

commit 7e31618f7fdc51d797a3bf22524731168de68553
Author: Michal Klobukowski <michal.klobukowski at contractors.roche.com>
Date:   Mon Dec 31 09:14:16 2018 +0100

    Clean up route-change-handlers imports
    
    Feature #14653
    
    Arvados-DCO-1.1-Signed-off-by: Michal Klobukowski <michal.klobukowski at contractors.roche.com>

diff --git a/src/routes/route-change-handlers.ts b/src/routes/route-change-handlers.ts
index 4118415a..ee48e6da 100644
--- a/src/routes/route-change-handlers.ts
+++ b/src/routes/route-change-handlers.ts
@@ -3,6 +3,9 @@
 // SPDX-License-Identifier: AGPL-3.0
 
 import { History, Location } from 'history';
+import { match } from 'react-router-dom';
+import { Dispatch } from 'redux';
+import { ThunkAction } from 'redux-thunk';
 import { RootStore } from '~/store/store';
 import * as R from '~/routes/routes';
 import * as WA from '~/store/workbench/workbench-actions';
@@ -10,8 +13,6 @@ import { navigateToRootProject } from '~/store/navigation/navigation-action';
 import { dialogActions } from '~/store/dialog/dialog-actions';
 import { contextMenuActions } from '~/store/context-menu/context-menu-actions';
 import { searchBarActions } from '~/store/search-bar/search-bar-actions';
-import { match } from 'react-router-dom';
-import { Dispatch } from 'redux';
 
 export const addRouteChangeHandlers = (history: History, store: RootStore) => {
     const handler = handleLocationChange(store);

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list