[ARVADOS] updated: 1.3.0-126-g7252f5a92

Git user git at public.curoverse.com
Thu Dec 20 11:02:01 EST 2018


Summary of changes:
 lib/dispatchcloud/scheduler/run_queue_test.go | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

       via  7252f5a926ebcd8fdf0048a4c622d7ee95cbd3b7 (commit)
      from  c6b8556dfb4f71c5ccc6041b48061fdb1c00c3b2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


commit 7252f5a926ebcd8fdf0048a4c622d7ee95cbd3b7
Author: Tom Clegg <tclegg at veritasgenetics.com>
Date:   Thu Dec 20 11:00:10 2018 -0500

    14360: Test for errant Create calls after failure.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg at veritasgenetics.com>

diff --git a/lib/dispatchcloud/scheduler/run_queue_test.go b/lib/dispatchcloud/scheduler/run_queue_test.go
index 5050d884a..be13e1c34 100644
--- a/lib/dispatchcloud/scheduler/run_queue_test.go
+++ b/lib/dispatchcloud/scheduler/run_queue_test.go
@@ -165,14 +165,14 @@ func (*SchedulerSuite) TestUseIdleWorkers(c *check.C) {
 	}
 }
 
-// Shutdown some nodes if Create() fails -- and without even calling
-// Create(), if AtQuota() is true.
+// If Create() fails, shutdown some nodes, and don't call Create()
+// again.  Don't call Create() at all if AtQuota() is true.
 func (*SchedulerSuite) TestShutdownAtQuota(c *check.C) {
 	for quota := 0; quota < 2; quota++ {
 		c.Logf("quota=%d", quota)
 		shouldCreate := []arvados.InstanceType{}
 		for i := 0; i < quota; i++ {
-			shouldCreate = append(shouldCreate, test.InstanceType(1))
+			shouldCreate = append(shouldCreate, test.InstanceType(3))
 		}
 		queue := test.Queue{
 			ChooseType: func(ctr *arvados.Container) (arvados.InstanceType, error) {
@@ -180,12 +180,21 @@ func (*SchedulerSuite) TestShutdownAtQuota(c *check.C) {
 			},
 			Containers: []arvados.Container{
 				{
-					UUID:     test.ContainerUUID(1),
-					Priority: 1,
+					UUID:     test.ContainerUUID(2),
+					Priority: 2,
 					State:    arvados.ContainerStateLocked,
 					RuntimeConstraints: arvados.RuntimeConstraints{
-						VCPUs: 1,
-						RAM:   1 << 30,
+						VCPUs: 2,
+						RAM:   2 << 30,
+					},
+				},
+				{
+					UUID:     test.ContainerUUID(3),
+					Priority: 3,
+					State:    arvados.ContainerStateLocked,
+					RuntimeConstraints: arvados.RuntimeConstraints{
+						VCPUs: 3,
+						RAM:   3 << 30,
 					},
 				},
 			},

-----------------------------------------------------------------------


hooks/post-receive
-- 




More information about the arvados-commits mailing list