[ARVADOS] created: 1.1.4-733-gc4e13fdbb

[Git user]

        at  c4e13fdbb3f7de9d587f9c07b4711c08c7eae09e (commit)


commit c4e13fdbb3f7de9d587f9c07b4711c08c7eae09e
Author: Tom Clegg <tclegg at veritasgenetics.com>
Date:   Wed Aug 1 12:56:31 2018 -0400

    13934: Add comment to guard dispatch bugfix.
    
    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tclegg at veritasgenetics.com>

diff --git a/sdk/go/dispatch/dispatch.go b/sdk/go/dispatch/dispatch.go
index c3d603099..e0dc2eefd 100644
--- a/sdk/go/dispatch/dispatch.go
+++ b/sdk/go/dispatch/dispatch.go
@@ -165,7 +165,13 @@ func (d *Dispatcher) checkForUpdates(filters [][]interface{}, todo map[string]*r
 	offset := 0
 	for {
 		params["offset"] = offset
+
+		// This list variable must be a new one declared
+		// inside the loop: otherwise, items in the API
+		// response would get deep-merged into the items
+		// loaded in previous iterations.
 		var list arvados.ContainerList
+
 		err := d.Arv.List("containers", params, &list)
 		if err != nil {
 			log.Printf("Error getting list of containers: %q", err)

-----------------------------------------------------------------------


hooks/post-receive
--